Skip to content

feat: add DeleteAll methods to keyring#112

Merged
mikkeloscar merged 3 commits intozalando:masterfrom
avallete:avallete/feat-add-delete-all
Sep 23, 2024
Merged

feat: add DeleteAll methods to keyring#112
mikkeloscar merged 3 commits intozalando:masterfrom
avallete:avallete/feat-add-delete-all

Conversation

@avallete
Copy link
Copy Markdown
Contributor

Possible implementation of #111

@szuecs
Copy link
Copy Markdown
Member

szuecs commented Sep 10, 2024

@avallete please sign-off all commits to fix DCO check, thanks!

@szuecs szuecs added the major moderate risk, for example new API, small changes that have no risk label Sep 10, 2024
Signed-off-by: avallete <andrew.valleteau@supabase.io>
Signed-off-by: avallete <andrew.valleteau@supabase.io>
@avallete avallete force-pushed the avallete/feat-add-delete-all branch from 3ad9698 to 18c3ffd Compare September 10, 2024 21:00
Signed-off-by: avallete <andrew.valleteau@supabase.io>
@szuecs
Copy link
Copy Markdown
Member

szuecs commented Sep 13, 2024

👍

@szuecs
Copy link
Copy Markdown
Member

szuecs commented Sep 13, 2024

It will likely take some time until @mikkeloscar is back, max one month, FYI.

@mikkeloscar
Copy link
Copy Markdown
Member

👍

@mikkeloscar mikkeloscar merged commit ead676f into zalando:master Sep 23, 2024
@avallete avallete deleted the avallete/feat-add-delete-all branch October 5, 2024 11:15
@avallete
Copy link
Copy Markdown
Contributor Author

Hey @mikkeloscar

Sorry to dig this one up, but I wonder if there is a release of the package including this feature is scheduled and when should it come around. So I can get myself a reminder and upgrade to it in our codebase.

@mikkeloscar
Copy link
Copy Markdown
Member

New release: https://github.com/zalando/go-keyring/releases/tag/v0.2.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major moderate risk, for example new API, small changes that have no risk

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants