Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: zalando/go-keyring
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.3
Choose a base ref
...
head repository: zalando/go-keyring
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.4
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 15, 2024

  1. Fix race condition in prompt handling 

    The current approach to handling prompts involves calling for a prompt
and then registering a signal handler for a response that indicates the
prompt had completed. In most cases, if the user were to take action,
this would be quite slow. However, in the case of automatic responses to
the prompt, the signal response may appear before the signal handler is
configured, resulting in blocking forever.

This commit moves the call for a prompt after the signal handling has
been configured, closing the race window.

Signed-off-by: William Martin <williammartin@github.com>
    @williammartin
    williammartin committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    70fd443 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #105 from williammartin/master 

    Fix suspected race condition in prompt handling
    @mikkeloscar
    mikkeloscar authored Mar 15, 2024
    Configuration menu
    Copy the full SHA
    987647a View commit details
    Browse the repository at this point in the history
Loading