libcontainer: Make the workloads injectable#1403
Merged
Furisto merged 6 commits intoyouki-dev:mainfrom Mar 13, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 68.95% 68.88% -0.08%
==========================================
Files 120 121 +1
Lines 13156 13177 +21
==========================================
+ Hits 9072 9077 +5
- Misses 4084 4100 +16 |
22ff520 to
af830cb
Compare
e4aa804 to
5105b01
Compare
Member
Author
|
@Furisto May I ask you to review this PR? |
Furisto
reviewed
Mar 8, 2023
| if proc.args().is_some() { | ||
| ExecutorManager::exec(spec) | ||
| args.executor_manager.exec(spec)?; | ||
| unreachable!("process image should have been replaced after exec"); |
Collaborator
There was a problem hiding this comment.
The image will not have been replaced if you are using wasm to execute the workload and youki will crash in that case.
5 tasks
Bumps [clap_complete](https://github.com/clap-rs/clap) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.1.1...clap_complete-v4.1.2) --- updated-dependencies: - dependency-name: clap_complete dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [clap](https://github.com/clap-rs/clap) from 4.1.4 to 4.1.6. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v4.1.4...v4.1.6) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [clap_complete](https://github.com/clap-rs/clap) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_complete-v4.1.2...clap_complete-v4.1.3) --- updated-dependencies: - dependency-name: clap_complete dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Signed-off-by: utam0k <k0ma@utam0k.jp>
Member
Author
|
@Furisto PTAL |
Furisto
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows flexibility by allowing libcontainer users to create and inject workloads.
For example, users of libcontainer can add their favorite wasm runtime and not use the normal workloads.