fix(editor): Fixed events for multiple editors by making them not global#503
Merged
Darginec05 merged 1 commit intoyoopta-editor:masterfrom May 27, 2025
OpenOrion:master
Merged
fix(editor): Fixed events for multiple editors by making them not global#503Darginec05 merged 1 commit intoyoopta-editor:masterfrom OpenOrion:master
Darginec05 merged 1 commit intoyoopta-editor:masterfrom
OpenOrion:master
Conversation
|
@afshawnlotfi is attempting to deploy a commit to the dargo's projects Team on Vercel. A member of the Team first needs to authorize it. |
1 task
Collaborator
|
super! will be merged soon |
Darginec05
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#466
When there are multiple instances of the YooptaEditor the onChange event is triggered for all instances with the same value AND
Also if you perform undo redo actions with ctrl+z and ctrl+y they are applied for all editor instances not only for the focused one (WIP)
Fixes # (issue)
I have made it such that the editors have their own local events instead of global and now callbacks are local per editor instantiation.
Type of change
Please tick the relevant option.
Checklist: