Respect relativePaths in local package paths #1498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this a local package defined in an included file would not respect relativePaths: true. This fixes yonaskolb#1497.
yonaskolb
reviewed
Aug 25, 2024
Sources/ProjectSpec/Project.swift
Outdated
| .object("aggregateTargets", AggregateTarget.pathProperties), | ||
| .object("schemes", Scheme.pathProperties), | ||
| .object("projectReferences", ProjectReference.pathProperties), | ||
| .object("packages", SwiftPackage.pathProperties) |
Owner
There was a problem hiding this comment.
Could you add support for localPackages as well
Owner
There was a problem hiding this comment.
I've added this in another commit
yonaskolb
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this a local package defined in an included file would not respect relativePaths: true.
This fixes #1497.
This is a breaking change because this changes how paths are resolved.