Support for Strings Catalogs (Xcode 15) #1421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t asset catalogs are added in the resources build phase
MojtabaHs
reviewed
Feb 7, 2024
| resourceTags: | ||
| - tag1 | ||
| - tag2 | ||
| - String Catalogs/Localizable.xcstrings |
There was a problem hiding this comment.
This seems not following the naming pattern.
MojtabaHs
reviewed
Feb 7, 2024
MojtabaHs
left a comment
There was a problem hiding this comment.
Thanks for the contribution.
I'm suggesting to add more documentation about this change and also, review the naming pattern for the arguments.
yonaskolb
approved these changes
Feb 14, 2024
Owner
yonaskolb
left a comment
There was a problem hiding this comment.
Fantastic, thank you @nicolasbosi95!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode 15 introduced String Catalogs (
.xcstringsfiles), which intend to replace the now legacy.stringsandstringsdictfiles.These changes add support to strings catalogs in the following ways:
text.json.xcstring.knownRegionsof the project. This is because string catalogs do not reside in dedicated per-locale.lprojdirectories, so detectingknownRegionsexclusively based on existing.lprojdirectories is no longer reliable.