Skip to content

Enable adding local Swift packages to the project root #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yonaskolb merged 3 commits into from
Apr 7, 2024
Merged

Enable adding local Swift packages to the project root #1413

yonaskolb merged 3 commits into from
Apr 7, 2024

Conversation

@hiltonc
Copy link
Contributor

@hiltonc hiltonc commented Nov 6, 2023 •
edited
Loading

This enables adding local Swift packages to the project root. This can be done in one of two ways:

  1. Use a "" group for a package:
packages:
  MyPackage:
    path: MyPackage
    group: ""
  1. Use "" for the localPackagesGroup option:
options:
  localPackagesGroup: ""

Resolves #1209

@hiltonc hiltonc changed the title Enable adding local Swift packages to the project root. Resolves #1209 Enable adding local Swift packages to the project root Nov 6, 2023
@hiltonc hiltonc mentioned this pull request Nov 6, 2023
Closed
MartinP7r
MartinP7r approved these changes Nov 23, 2023
View reviewed changes
Copy link

@MartinP7r MartinP7r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@yonaskolb
Copy link
Owner

yonaskolb commented Feb 14, 2024

Thank you for this @hiltonc. Could you resolve the conflicts and make sure it still works after #1417 was merged

@OmranK
Copy link

OmranK commented Feb 25, 2024

Would this solution allow you to have Xcode project with local packages generated like this?
Screenshot 2024-02-25 at 6 42 49 AM

@hiltonc
Copy link
Contributor Author

hiltonc commented Feb 26, 2024

@OmranK yes, it should enable you to do that

@hiltonc hiltonc force-pushed the local-swift-packages-at-project-root branch from feb41c7 to 5fb2fcf Compare February 26, 2024 18:51
@hiltonc hiltonc changed the base branch from master to default_cache February 26, 2024 18:54
@hiltonc hiltonc changed the base branch from default_cache to master February 26, 2024 18:56
@hiltonc
Copy link
Contributor Author

hiltonc commented Feb 26, 2024

@yonaskolb I've resolved conflicts, tests pass, and I manually verified both configuration options.

@hiltonc hiltonc force-pushed the local-swift-packages-at-project-root branch from 5fb2fcf to feb41c7 Compare February 26, 2024 19:04
yonaskolb
yonaskolb approved these changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@yonaskolb yonaskolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hiltonc!

@yonaskolb yonaskolb merged commit 632ca2d into yonaskolb:master Apr 7, 2024
@hiltonc hiltonc deleted the local-swift-packages-at-project-root branch April 7, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yonaskolb yonaskolb yonaskolb approved these changes

+1 more reviewer

@MartinP7r MartinP7r MartinP7r approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

set 'no group' for local packages

4 participants

@hiltonc @yonaskolb @OmranK @MartinP7r