Fix issue with includes not working when no matches are found #1337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
reviewed
Apr 25, 2023
| return !defaultExcludedFiles.contains(where: { path.lastComponent == $0 }) | ||
| && !(path.extension.map(defaultExcludedExtensions.contains) ?? false) | ||
| && !excludePaths.contains(path) | ||
| // If includes is empty, it's included. If it's not empty, the path either needs to match exactly, or it needs to be a direct parent of an included path. |
Owner
There was a problem hiding this comment.
Is this comment still accurate, or does it need changing?
yonaskolb
approved these changes
Aug 16, 2023
Owner
|
Thanks @shnhrrsn! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised in #1283, where a single includes glob pattern with no matches causes the
isIncludedPathfunction to ignore the includes restriction.The problem occurs when the
isIncludedPathfunction checks ifincludePathsis empty, which is true if there are no include patterns or if there are no matches for a pattern. To fix this issue, I changedincludePathsto an optional, usingnilto indicate that all paths should be allowed.isIncludedPathfunction to handle optionalincludePaths.getSourceChildrenfunction to accept an optionalincludePathsparameter.getSourceFilesfunction to work with optionalincludePaths.includePaths.Additionally, I added a new test case to verify the correct behavior when no matches are found for an includes pattern.