fix: Add endpointslices to list of resources in chart roles#545
Merged
yonahd merged 2 commits intoyonahd:mainfrom Jan 4, 2026
Merged
fix: Add endpointslices to list of resources in chart roles#545yonahd merged 2 commits intoyonahd:mainfrom
endpointslices to list of resources in chart roles#545yonahd merged 2 commits intoyonahd:mainfrom
Conversation
Owner
|
@dabico Please bump the chart version in chart.yaml and then run |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
=======================================
Coverage 45.81% 45.81%
=======================================
Files 69 69
Lines 3933 3933
=======================================
Hits 1802 1802
Misses 1832 1832
Partials 299 299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@yonahd hi, done! |
yonahd
approved these changes
Jan 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
endpointslicesto the list ofresourcesto theClusterRole/Roleinstalled by the chart.What this PR does / why we need it?
Without this permission,
Serviceinstances might be omitted from the final report when runningkoras a CRON job on a cluster.PR Checklist
GitHub Issue
Closes #544