Skip to content

Properly pass around browser to isPointInAnyRect rather than check for browser namespace#2362

Merged
Kuuuube merged 3 commits intoyomidevs:masterfrom
Kuuuube:browser-detection
Mar 30, 2026
Merged

Properly pass around browser to isPointInAnyRect rather than check for browser namespace#2362
Kuuuube merged 3 commits intoyomidevs:masterfrom
Kuuuube:browser-detection

Conversation

@Kuuuube
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube commented Mar 29, 2026

Followup to #2358, this will be broken.

@Kuuuube Kuuuube added the kind/bug The issue or PR is regarding a bug label Mar 29, 2026
@Kuuuube Kuuuube requested a review from a team as a code owner March 29, 2026 19:41
@Kuuuube Kuuuube added the browser/chrome The issue is Chrome-only label Mar 29, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d86ea0b27d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@Kuuuube Kuuuube added this pull request to the merge queue Mar 30, 2026
Merged via the queue into yomidevs:master with commit 63e5a81 Mar 30, 2026
24 of 25 checks passed
@Kuuuube Kuuuube deleted the browser-detection branch March 30, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

browser/chrome The issue is Chrome-only kind/bug The issue or PR is regarding a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants