Skip to content

[fix, de] Fix außer showing first ausser#2354

Merged
Kuuuube merged 3 commits intoyomidevs:masterfrom
daxida:de-ausser
Mar 30, 2026
Merged

[fix, de] Fix außer showing first ausser#2354
Kuuuube merged 3 commits intoyomidevs:masterfrom
daxida:de-ausser

Conversation

@daxida
Copy link
Copy Markdown

@daxida daxida commented Mar 26, 2026

Closes #2353

See more context, and how to test if this change works in the relevant issue.

* See more context in the relevant issue
@daxida daxida requested a review from a team as a code owner March 26, 2026 14:26
@StefanVukovic99
Copy link
Copy Markdown
Member

Seems it causes the problem from #1075 to reoccur.

@daxida
Copy link
Copy Markdown
Author

daxida commented Mar 26, 2026

Can't reproduce (on Firefox with local dev built from this branch).

Tried both character and word for scan resolution.

Only one match.

image

I have oppido in the dict.

image

Edit: same result for oppidorum

@StefanVukovic99
Copy link
Copy Markdown
Member

Scan or search resolution? Translation > Search resolution needs to be Letter

@daxida
Copy link
Copy Markdown
Author

daxida commented Mar 26, 2026

That indeed works and oppido is shown first.

I'm not entirely convinced that the longest-first behaviour (oppidum over oppido) is preferable in every case, but let's assume so.

Any chance someone could add a test for that case or the ausser/außer? It's a pain to test changes if I have to re-load the extension every time.

@daxida
Copy link
Copy Markdown
Author

daxida commented Mar 26, 2026

Let me know now. The global diff is easier to visualize that the last commit only.

Nothing clever, the reasoning was already in the issue. Keep the (personally, dubious) logic of longer is best, but don't go splicing around if you find the original word.

@Kuuuube Kuuuube added this pull request to the merge queue Mar 30, 2026
Merged via the queue into yomidevs:master with commit 530d165 Mar 30, 2026
24 of 25 checks passed
@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[German]: Setting Yomitan's language to German (de) causes Swiss Spelling to match first even if selected word uses standard spelling.

3 participants