Add browser.tabs.captureVisibleTab as a fallback for chrome.tabs.captureVisibleTab#2328
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ceb58dc17
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Fixes #1121
Looking past the AI mistakes in #2327, considering
browser.tabs.captureVisibleTabis fine. I've added it as a fallback for ifchrome.tabs.captureVisibleTabfails. I can't replicatechrome.tabs.captureVisibleTabfailing on Firefox myself but if this fixes anything that's great.Shouldn't need any permission changes.
browser.tabs.captureVisibleTabruns without issues with the current manifest permissions.Also notably,
browser.tabs.captureVisibleTabdoes not exist on chromium browsers.