Skip to content

Remove shift to prevent mutating content when running _convertGlossaryStructuredContentRecursive#2287

Merged
Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube:fix-mutation-again
Jan 15, 2026
Merged

Remove shift to prevent mutating content when running _convertGlossaryStructuredContentRecursive#2287
Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube:fix-mutation-again

Conversation

@Kuuuube
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube commented Jan 14, 2026

Same change as #2274 but in the other function now. Nothing gets pushed back to content anymore so the shift is unnecessary.

Fixes #2286

Bug only happens if a glossary plain handlebars is rendered before other glossary handlebars.

@Kuuuube Kuuuube requested a review from a team as a code owner January 14, 2026 18:00
@Kuuuube Kuuuube added the kind/bug The issue or PR is regarding a bug label Jan 14, 2026
@Kuuuube Kuuuube added this pull request to the merge queue Jan 15, 2026
Merged via the queue into yomidevs:master with commit 401031a Jan 15, 2026
19 of 25 checks passed
@Kuuuube Kuuuube deleted the fix-mutation-again branch January 15, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/bug The issue or PR is regarding a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

{glossary} and {glossary-plain-no-dictionary} issue

2 participants