Skip to content

Add option to reduce anki dupe check time by checking with barebone notes before full note creation#2285

Merged
Kuuuube merged 21 commits intoyomidevs:masterfrom
hearjest:Pop-up-duplicate-quick-check-DRAFT
Mar 16, 2026
Merged

Add option to reduce anki dupe check time by checking with barebone notes before full note creation#2285
Kuuuube merged 21 commits intoyomidevs:masterfrom
hearjest:Pop-up-duplicate-quick-check-DRAFT

Conversation

@hearjest
Copy link
Copy Markdown

No description provided.

@hearjest hearjest changed the title initial method functions that checks anki for note duplicates with barebone notes before actual anki note creation due to note creation time Jan 14, 2026
@bpwhelan
Copy link
Copy Markdown

bpwhelan commented Feb 25, 2026

Built this and tested for a few hours. Seems very fast and accurate, but I haven't gotten long duplicate checks in a while on main branch personally.

@hearjest
Copy link
Copy Markdown
Author

Built this and tested for a few hours. Seems very fast and accurate, but I haven't gotten long duplicate checks in a while.

thank you for the reply
aside from getting a proper icon to show that a dupe check is ongoing, is there anything you want more out of this?


if this gets implemented i personally will want to add this function as an option in the settings
im pretty sure there is also room for performance improvements as well

@hearjest hearjest marked this pull request as ready for review March 4, 2026 04:59
@hearjest hearjest requested a review from a team as a code owner March 4, 2026 04:59
@hearjest hearjest marked this pull request as draft March 4, 2026 05:02
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b386a89b5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

hearjest added 2 commits March 4, 2026 22:28
…ted ; changed the action hotkey indexer in +_createSaveButtons to count the actual buttons ".action-button-container", and not the temp <p> elements
@hearjest hearjest marked this pull request as ready for review March 5, 2026 03:29
@hearjest hearjest marked this pull request as draft March 5, 2026 03:29
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3ddbea11b5

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

…ck should work regardless of custom card format
@hearjest hearjest marked this pull request as ready for review March 5, 2026 05:11
@hearjest hearjest marked this pull request as draft March 5, 2026 05:11
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d962936ae9

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@hearjest
Copy link
Copy Markdown
Author

hearjest commented Mar 8, 2026

@Kuuuube When you have the time, could you look at this?
I've just reused the (appropriate) icons and applied opacity and disabled to the "buttons".
i'm thinking of adding this as an advanced option in the settings

image image

@hearjest
Copy link
Copy Markdown
Author

hearjest commented Mar 8, 2026

@Kuuuube When you have the time, could you look at this?

I've just reused the (appropriate) icons and applied opacity and disabled to the "buttons".

i'm thinking of adding this as an advanced option in the settings

image image

Oops the last column for the one with quick dupe check should be the total time

@hearjest
Copy link
Copy Markdown
Author

hearjest commented Mar 9, 2026

bro why does broken link checker keep failing?

@Kuuuube Kuuuube added kind/enhancement The issue or PR is a new feature or request area/anki The issue or PR is related to Anki integration labels Mar 9, 2026
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres also two spots where you've removed a newline. That's weird and makes the diff needlessly bigger.

@Kuuuube Kuuuube marked this pull request as ready for review March 9, 2026 18:45
@Kuuuube Kuuuube changed the title functions that checks anki for note duplicates with barebone notes before actual anki note creation due to note creation time Add option to reduce anki dupe check time by checking with barebone notes before full note creation Mar 9, 2026
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Brian <bzengprsnl@gmail.com>
@hearjest
Copy link
Copy Markdown
Author

hearjest commented Mar 9, 2026

Theres also two spots where you've removed a newline. That's weird and makes the diff needlessly bigger.

I thought I put them there so I removed them, my mistake

@Kuuuube Kuuuube added this pull request to the merge queue Mar 16, 2026
Merged via the queue into yomidevs:master with commit 8387894 Mar 16, 2026
19 of 26 checks passed
@hearjest hearjest deleted the Pop-up-duplicate-quick-check-DRAFT branch March 17, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/anki The issue or PR is related to Anki integration kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants