Allow scanning popup content by default #2264
Merged
Kuuuube merged 2 commits intoyomidevs:masterfrom Dec 14, 2025
Merged
Conversation
jamesmaa
approved these changes
Dec 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bit weird to not allow this by default. It was also previously considered for being default 5 years ago as the feature was already considered stable by then (FooSoft#479).
For an example use case: many dicts contain example sentences that a user may not know words in and may want to look up.
Using 10 as default seems like a sane number nobody would really hit besides very niche use cases.
Considered also enabling
Allow scanning popup source terms(scanning.enableOnPopupExpressions) by default but it appears to cause some wonky behavior on mobile.