Skip to content

Remove wildcard handling from text-scanner entirely#2241

Merged
Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube:remove-matchTypePrefix-text-scanner
Nov 11, 2025
Merged

Remove wildcard handling from text-scanner entirely#2241
Kuuuube merged 1 commit intoyomidevs:masterfrom
Kuuuube:remove-matchTypePrefix-text-scanner

Conversation

@Kuuuube
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube commented Nov 10, 2025

Somewhat of a followup to #2145

#2145 fixes wildcard scanning making lookups super laggy on normal webpages. But they can still be messed up when using the popup to hover words on the search page.

The search page does not even use this setting to determine whether or not to search using wildcards. In theory it may have been possible to scan *わ for example on a webpage and have that be a wildcard search. But this is silly and nobody complained when I removed this behavior in #2145 so it makes sense to just remove this entirely.

I'm not removing the wildcard setting itself since it probably should control the function on the search page (currently it does nothing). I'll leave that to a future pr.

This does not change any behavior with how the search page handles wildcards.

@Kuuuube Kuuuube requested a review from a team as a code owner November 10, 2025 18:03
@Kuuuube Kuuuube added kind/bug The issue or PR is regarding a bug area/performance The issue or PR is related to performance labels Nov 10, 2025
@Kuuuube Kuuuube added this pull request to the merge queue Nov 11, 2025
Merged via the queue into yomidevs:master with commit 5b5f6f0 Nov 11, 2025
25 checks passed
@Kuuuube Kuuuube deleted the remove-matchTypePrefix-text-scanner branch November 11, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/performance The issue or PR is related to performance kind/bug The issue or PR is regarding a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants