Make structured content extraction for glossary-plain recursive to more easily ensure correct ordering#2240
Merged
Kuuuube merged 1 commit intoyomidevs:masterfrom Nov 11, 2025
Conversation
…re easily ensure correct ordering
Casheeew
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned here #2212 (comment)
The existing non-recursive method would throw spread arrays into the queue instead of handling them right away. Some dicts have data in arrays and not in arrays around the same level of nesting. This can lead to entries being ordered wrong.
With recursion it's quite easy to handle all data types right as they're seen to ensure correct ordering.