Skip to content

feat: Adjust the template to working with protolint#1

Merged
yoheimuta merged 4 commits intomasterfrom
adjust-template
Jul 3, 2022
Merged

feat: Adjust the template to working with protolint#1
yoheimuta merged 4 commits intomasterfrom
adjust-template

Conversation

@yoheimuta
Copy link
Copy Markdown
Owner

No description provided.

Comment thread entrypoint.sh Outdated
# Install protolint
if ! [ -f "protolint" ]; then
echo "🔄 Installing protolint v${INPUT_PROTOLINT_VERSION}..."
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v${INPUT_PROTOLINT_VERSION}/protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

Comment thread entrypoint.sh Outdated
# Install protolint
if ! [ -f "protolint" ]; then
echo "🔄 Installing protolint v${INPUT_PROTOLINT_VERSION}..."
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v${INPUT_PROTOLINT_VERSION}/protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

Comment thread entrypoint.sh Outdated
if ! [ -f "protolint" ]; then
echo "🔄 Installing protolint v${INPUT_PROTOLINT_VERSION}..."
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v${INPUT_PROTOLINT_VERSION}/protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
tar zxf protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

Comment thread entrypoint.sh Outdated
misspell -locale="${INPUT_LOCALE}" . \
| reviewdog -efm="%f:%l:%c: %m" \
-name="linter-name (misspell)" \
./protolint ${INPUT_PROTOLINT_FLAGS} \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [shellcheck] reported by reviewdog 🐶
Double quote to prevent globbing and word splitting. SC2086

Comment thread entrypoint.sh Outdated
Comment on lines +12 to +13
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v${INPUT_PROTOLINT_VERSION}/protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
tar zxf protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v${INPUT_PROTOLINT_VERSION}/protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
tar zxf protolint_${INPUT_PROTOLINT_VERSION}_Linux_x86_64.tar.gz
curl -sSOL https://github.com/yoheimuta/protolint/releases/download/v"${INPUT_PROTOLINT_VERSION}"/protolint_"${INPUT_PROTOLINT_VERSION}"_Linux_x86_64.tar.gz
tar zxf protolint_"${INPUT_PROTOLINT_VERSION}"_Linux_x86_64.tar.gz

Comment thread entrypoint.sh Outdated
misspell -locale="${INPUT_LOCALE}" . \
| reviewdog -efm="%f:%l:%c: %m" \
-name="linter-name (misspell)" \
./protolint ${INPUT_PROTOLINT_FLAGS} \
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[shellcheck (suggestion)] reported by reviewdog 🐶

Suggested change
./protolint ${INPUT_PROTOLINT_FLAGS} \
./protolint "${INPUT_PROTOLINT_FLAGS}" \

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2022

🏷️ [bumpr] Next version:v0.1.0

@yoheimuta yoheimuta merged commit d2a490d into master Jul 3, 2022
@yoheimuta yoheimuta deleted the adjust-template branch July 3, 2022 03:09
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 3, 2022

🚀 [bumpr] Bumped! New version:v0.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant