Chore: Add builtin dependencies on linux#284
Conversation
BigRoy
left a comment
There was a problem hiding this comment.
LGTM - bit worried the print statement may be scary too many if it prints a lot of modules most of the times. We may want to massage the wording so it's less scary, e.g.
"Skipping non-available standard library: '{module_name}'"
OR do the reverse, print the ones that DO find their way:
"Including standard library in build '{module_name}'"
The latter may actually make for better logs to debug the building with? @iLLiCiTiT thoughts?
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
At the end that is not the important information as the list is in setup.py, we do care if it is NOT found, we should revisit the module and find out why it is missing. Is platform specific? Move it to platform specific logic... Is not available anymore? -> Is it something we rely on? -> Can we remove it? (That's why I think |
Changelog Description
Explicitly tell which linux specific built-in dependencies to keep.
Additional info
We found out that
resourceis missing in linux build which is crutial for applications addon to work. There might be more dependencies that are missing, hopefully we don't use them.Testing notes:
resourceshould be available.