Resolve environment variables in dev bundle addon paths#253
Merged
Resolve environment variables in dev bundle addon paths#253
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for environment variable resolution in dev bundle addon paths using the standard {VAR_NAME} format. This enables dev bundles to work across multiple platforms by setting appropriate environment variables.
- Wraps the path formatting in a try-catch block to handle missing environment variables gracefully
- Logs a warning when environment variable resolution fails instead of crashing
- Uses
os.environdictionary to resolve environment variables in addon paths
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
iLLiCiTiT
reviewed
Sep 8, 2025
iLLiCiTiT
reviewed
Sep 8, 2025
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Sep 8, 2025
iLLiCiTiT
reviewed
Sep 8, 2025
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
iLLiCiTiT
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Add support of resolution of environment variables in dev bundle addon paths. You can use standard
{FOO_BAR}format within the path. This can be used to set dev bundle to work on multiple platforms provided the environment variable is set there.Additional info
This also needs PR in
ayon-core- ayon-core/#1429Testing notes:
{DEV_ADDONS}/ayon-core/client