Skip to content

App launcher: Store pid of launched process back to the json file#249

Merged
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/store-launched-process-pid
Aug 11, 2025
Merged

App launcher: Store pid of launched process back to the json file#249
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/store-launched-process-pid

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Aug 8, 2025

Changelog Description

Store PID of launched process back to the json file.

Additional information

The PID is important part of information that is not used at this moment but will be in near future.

Testing notes:

  1. Build AYON launcher, upload to server and use it in a bundle.
  2. Applications can be launched from AYON launcher or webactions.
  3. The json file will contain the pid.

@iLLiCiTiT iLLiCiTiT self-assigned this Aug 8, 2025
@iLLiCiTiT iLLiCiTiT added the type: enhancement Improvement of existing functionality or minor addition label Aug 8, 2025
@iLLiCiTiT iLLiCiTiT requested a review from antirotor August 8, 2025 09:31
antirotor
antirotor requested changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually can't see pid entry in json file after the process.

If I read the code correctly, it would write it there anyway even if no pid can be determined when process fails

antirotor
antirotor requested changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I didn't realize that app_launcher isn't used when running from the code. But that means we need to add that there too. Otherwise the compiled version works.

@antirotor antirotor mentioned this pull request Aug 8, 2025
Merged
@iLLiCiTiT iLLiCiTiT merged commit 06791ae into develop Aug 11, 2025
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/store-launched-process-pid branch August 11, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antirotor antirotor antirotor approved these changes

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iLLiCiTiT @antirotor