Skip to content

Windows: Desktop shortcut is created if shim is already installed#248

Merged
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/246-ay-8077_launcher-silent-install
Aug 8, 2025
Merged

Windows: Desktop shortcut is created if shim is already installed#248
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/246-ay-8077_launcher-silent-install

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Aug 7, 2025 •
edited
Loading

Changelog Description

Create desktop shortcut on windows even if shim is already installed. And shim install window is not shown if /VERYSILENT command is used.

Additional info

If shim was already installed the creation of shortcut did not happen because the installation process of shim did take care of it.

Testing notes:

  1. Create build and installer.
  2. Make sure you have already installed shim.
  3. Make sure you don't have AYON shortcut on desktop.
  4. Run the installer and check to create desktop shortcut.
  5. There should be desktop shortcut when installation finishes.

Resolves #246

@iLLiCiTiT iLLiCiTiT changed the title create windows shortcut even if shim is already installed Windows: Desktop shortcut is selected if shim is already installed Aug 7, 2025
@iLLiCiTiT iLLiCiTiT added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Aug 7, 2025
@iLLiCiTiT iLLiCiTiT self-assigned this Aug 7, 2025
@iLLiCiTiT iLLiCiTiT changed the title Windows: Desktop shortcut is selected if shim is already installed Windows: Desktop shortcut is created if shim is already installed Aug 7, 2025
@64qam
Copy link
Copy Markdown
Member

64qam commented Aug 7, 2025

fails during build-make-installer

Parsing [InstallDelete] section, line 48
Parsing [UninstallDelete] section, line 53
Parsing [Run] section, line 64
Parsing [Files] section, line 59
Parsing [Files] section, line 60
   Reading version info: C:\Users\qam\code\ayon-launcher\build\output\README.md
Compiling [Code] section
Error on line 76 in C:\Users\qam\code\ayon-launcher\inno_setup.iss: Column 3:
Unknown identifier 'HeadlessArg'
Compile aborted.
Traceback (most recent call last):
  File "C:\Users\qam\code\ayon-launcher\tools\build_post_process.py", line 855, in <module>
    main()
  File "C:\Users\qam\code\ayon-launcher\tools\build_post_process.py", line 851, in main
    create_installer(ayon_root, build_root)
  File "C:\Users\qam\code\ayon-launcher\tools\build_post_process.py", line 819, in create_installer
    installer_path = _create_installer(
  File "C:\Users\qam\code\ayon-launcher\tools\build_post_process.py", line 774, in _create_installer
    return _create_windows_installer(*args, **kwargs)
  File "C:\Users\qam\code\ayon-launcher\tools\build_post_process.py", line 686, in _create_windows_installer
    raise ValueError("Installer was not created")
ValueError: Installer was not created
>>> Restoring current directory
*** All done in 74 secs. You will find AYON and build log in '.\build' directory.```

@iLLiCiTiT
Copy link
Copy Markdown
Member Author

iLLiCiTiT commented Aug 7, 2025

fails during build-make-installer

Fixed.

@64qam
Copy link
Copy Markdown
Member

64qam commented Aug 7, 2025

Installer has been installed, but an icon hasn't appeared on desktop

@iLLiCiTiT
Copy link
Copy Markdown
Member Author

iLLiCiTiT commented Aug 8, 2025

Did you check the Create a desktop shortcut?
image

m-u-r-p-h-y
m-u-r-p-h-y approved these changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@m-u-r-p-h-y m-u-r-p-h-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Desktop icon was created. Even with shim already installed

image

@iLLiCiTiT iLLiCiTiT merged commit cc4fbb5 into develop Aug 8, 2025
1 check passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/246-ay-8077_launcher-silent-install branch August 8, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-u-r-p-h-y m-u-r-p-h-y m-u-r-p-h-y approved these changes

@64qam 64qam Awaiting requested review from 64qam

@MilaKudr MilaKudr Awaiting requested review from MilaKudr

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AY-8077_Launcher silent install

3 participants

@iLLiCiTiT @64qam @m-u-r-p-h-y