Skip to content

Deadline: Add docs for Process submitted job on farm plugin#135

Merged
MustafaJafar merged 10 commits intomainfrom
OP-8268_AOV-filter-for-Ftrack-family
Sep 13, 2024
Merged

Deadline: Add docs for Process submitted job on farm plugin#135
MustafaJafar merged 10 commits intomainfrom
OP-8268_AOV-filter-for-Ftrack-family

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Feb 16, 2024 •
edited by MustafaJafar
Loading

Changelog Description

Add docs for Process submitted job on farm plugin.

TODO:

  • Add definitions for the Process submitted job on farm plugin settings.

Additional Info

This PR was originally created for documenting families_transfer attribute OP-8268

@tokejepsen tokejepsen requested a review from kalisp February 16, 2024 16:23
@tokejepsen tokejepsen mentioned this pull request Feb 16, 2024
Merged
BigRoy
BigRoy reviewed Feb 16, 2024
View reviewed changes
@kalisp kalisp assigned antirotor and unassigned kalisp Feb 19, 2024
@tokejepsen tokejepsen changed the title Document families_transfer attribute on ProcessSubmittedJobOnFarm Document families_transfer attribute on ProcessSubmittedJobOnFarm - OP-8268 Feb 20, 2024
@tokejepsen
Merge branch 'main' into OP-8268_AOV-filter-for-Ftrack-family
bb05565 
# Conflicts:
#	website/docs/addon_deadline_admin.md
@ynbot
Copy link
Copy Markdown

ynbot commented May 7, 2024

Task linked: OP-8268 AOV filter for Ftrack family

@MustafaJafar MustafaJafar self-assigned this Sep 9, 2024
@MustafaJafar MustafaJafar changed the title Document families_transfer attribute on ProcessSubmittedJobOnFarm - OP-8268 Deadline: Add docs for Process submitted job on farm plugin Sep 9, 2024
@MustafaJafar
Copy link
Copy Markdown
Member

MustafaJafar commented Sep 9, 2024 •
edited
Loading

This PR existed for some time.
It was originally created for documenting families_transfer attribute OP-8268
Personally, we can't document an attribute in a section without documenting the whole section therefore, I stretched the scope of this PR a little bit.

This PR still lacks some definitions for the Process submitted job on farm plugin settings

MustafaJafar
MustafaJafar approved these changes Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update this PR. and I think it's ready to merge.
Feel free to review and ensure the documentation communicates well.

BigRoy
BigRoy reviewed Sep 12, 2024
View reviewed changes
@MustafaJafar MustafaJafar self-requested a review September 12, 2024 09:57
@kalisp
Copy link
Copy Markdown
Member

kalisp commented Sep 12, 2024

I tried to clean up a bit chunk size issue in ynput/ayon-deadline#33 , so documentation might need to clean it up too.

@MustafaJafar MustafaJafar requested a review from BigRoy September 12, 2024 21:26
MustafaJafar
MustafaJafar approved these changes Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@MustafaJafar MustafaJafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've update the PR in compliance with ynput/ayon-deadline#33
Also, added missing definitions for settings.

BigRoy
BigRoy reviewed Sep 12, 2024
View reviewed changes
BigRoy
BigRoy approved these changes Sep 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - just one small comment.

@MustafaJafar @BigRoy
Update website/docs/addon_deadline_admin.md
2ecc550 
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@MustafaJafar MustafaJafar merged commit e75d549 into main Sep 13, 2024
@MustafaJafar MustafaJafar deleted the OP-8268_AOV-filter-for-Ftrack-family branch September 13, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BigRoy BigRoy BigRoy approved these changes

@MustafaJafar MustafaJafar MustafaJafar approved these changes

@kalisp kalisp Awaiting requested review from kalisp

@antirotor antirotor Awaiting requested review from antirotor

@mkolar mkolar Awaiting requested review from mkolar

Assignees

@MustafaJafar MustafaJafar

@antirotor antirotor

Labels

addon: Deadline

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tokejepsen @ynbot @MustafaJafar @kalisp @BigRoy @mkolar @antirotor