Skip to content

Max: Implementation of the validator for model name #59

Merged
moonyuet merged 26 commits intodevelopfrom
enhancement/OP-7076_Validate-Model-Name
Mar 7, 2024
Merged

Max: Implementation of the validator for model name #59
moonyuet merged 26 commits intodevelopfrom
enhancement/OP-7076_Validate-Model-Name

Conversation

@moonyuet
Copy link
Copy Markdown
Member

@moonyuet moonyuet commented Feb 14, 2024

Changelog Description

Ported from Openpype: ynput/OpenPype#6164
Implement the validator for model name in 3dsmax

Additional info

The validation regex by default is (.*)_(?P<subset>.*)_(GEO) and
your model name should be {Some name}_{SubsetName}_GEO

Testing notes:

  1. Go to OP/AYON Settings
  2. Turn on Validate Model Name
  3. Set your preferred validation regex for checking your model name
  4. Validate Model Name would check your name accordingly with your validation regex

@ynbot ynbot added size/S type: enhancement Improvement of existing functionality or minor addition host: 3dsmax labels Feb 14, 2024
@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Feb 22, 2024

Im getting this error when validating the publish:

DEBUG: ['TeaCup01']
Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 96, in process
    invalid = self.get_invalid(instance)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 49, in get_invalid
    invalid_model_name = cls.get_invalid_model_name(instance, name)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 61, in get_invalid_model_name
    current_asset_name = instance.context.data["asset"]
KeyError: 'asset'

@moonyuet
Copy link
Copy Markdown
Member Author

moonyuet commented Feb 22, 2024

Im getting this error when validating the publish:

DEBUG: ['TeaCup01']
Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 96, in process
    invalid = self.get_invalid(instance)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 49, in get_invalid
    invalid_model_name = cls.get_invalid_model_name(instance, name)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 61, in get_invalid_model_name
    current_asset_name = instance.context.data["asset"]
KeyError: 'asset'

Im getting this error when validating the publish:

DEBUG: ['TeaCup01']
Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2402141620_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 96, in process
    invalid = self.get_invalid(instance)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 49, in get_invalid
    invalid_model_name = cls.get_invalid_model_name(instance, name)
  File "C:\Work\REPO\ayon-core\client\ayon_core\hosts\max\plugins\publish\validate_model_name.py", line 61, in get_invalid_model_name
    current_asset_name = instance.context.data["asset"]
KeyError: 'asset'

This happens mainly because the instance.context.data["asset"] switched to instance.context.data["folderPath"] in AYON. Should be working now with the latest commit.

LiborBatek
LiborBatek approved these changes Feb 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected.
Validator correctly kicks in. Select Invalid select the non valid geometry
Screenshot 2024-02-26 124048

And if correct then validates properly without error:
image

BigRoy
BigRoy reviewed Feb 28, 2024
View reviewed changes
antirotor
antirotor requested changes Feb 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make it more artist friendly, especially validator that will trigger probably very often. I know that we are not using it on many places, but publisher has already ability to show stuff.

Look at https://github.com/ynput/ayon-core/blob/develop/client/ayon_core/hosts/maya/plugins/publish/validate_node_ids.py

Maybe not the greatest example, but it is using PublishXmlValidationError and xml file located in help directory.

I do understand that this is pretty straightforward validation that is requiring simple action from artist, so I stating it here mainly as a reference.

@moonyuet moonyuet requested review from BigRoy and antirotor February 28, 2024 10:53
antirotor
antirotor requested changes Mar 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart that json file it looks a works great

client/ayon_core/settings/defaults/project_settings/max.json Outdated
Copy link
Copy Markdown
Member

@antirotor antirotor Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't probably be here in this PR

@moonyuet moonyuet requested a review from antirotor March 5, 2024 04:15
antirotor
antirotor approved these changes Mar 7, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@antirotor antirotor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for the changes!

@moonyuet moonyuet merged commit 7dc8505 into develop Mar 7, 2024
@moonyuet moonyuet deleted the enhancement/OP-7076_Validate-Model-Name branch March 7, 2024 10:27
@dee-ynput dee-ynput mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antirotor antirotor antirotor approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

@BigRoy BigRoy Awaiting requested review from BigRoy

Assignees

@antirotor antirotor

Labels

size/S type: enhancement Improvement of existing functionality or minor addition

Projects

PR reviewing
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@moonyuet @LiborBatek @BigRoy @antirotor @ynbot