Skip to content

Add 3DEqualizer support (port from OpenPype)#472

Merged
antirotor merged 5 commits intodevelopfrom
enhancement/add-3dequalizer-support
May 3, 2024
Merged

Add 3DEqualizer support (port from OpenPype)#472
antirotor merged 5 commits intodevelopfrom
enhancement/add-3dequalizer-support

Conversation

@antirotor
Copy link
Copy Markdown
Member

Changelog Description

Support of 3DEqualizer addon. Adding application to Applications addon and corresponding icon for the launcher.

Note

PR with port from OpenPype is ynput/ayon-equalizer#1

Testing notes:

  1. Build ayon-core and addons
  2. Build ayon-equalizer addon
  3. Upload all to server
  4. Modify your bundles to include them
  5. Set correct path in the Application Addon
  6. Add 3DEqualizer to your project anatomy
  7. Re-fresh launcher
  8. Run 3DEqualizer on task

@antirotor antirotor self-assigned this Apr 30, 2024
@ynbot ynbot added type: enhancement Improvement of existing functionality or minor addition size/XS labels Apr 30, 2024
@BigRoy
Copy link
Copy Markdown
Collaborator

BigRoy commented Apr 30, 2024

It's really time for an Addon to be able to register their own applications without requiring these changes in ayon core. Should we have that as a goal for ayon core 0.3.x so that addons can actually really be developed independently?

@iLLiCiTiT I suppose this is on the roadmap?

@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Apr 30, 2024

It's really time for an Addon to be able to register their own applications without requiring these changes in ayon core. Should we have that as a goal for ayon core 0.3.x so that addons can actually really be developed independently?

This is change in applications addon, not in ayon-core addon (it just lives in ayon core repository). And I have no idea how applications addon would be able to change it's settings model based on other addon. I guess this is a must-have.

@BigRoy
Copy link
Copy Markdown
Collaborator

BigRoy commented Apr 30, 2024

This is change in applications addon, not in ayon-core addon (it just lives in ayon core repository).

Yes, of course. Thanks.

And I have no idea how applications addon would be able to change it's settings model based on other addon. I guess this is a must-have.

I vaguely recall @martastain mentioned something a while back that seemed very closely related to this where one addon could somehow register e.g. applications from outside ayon core / applications plug-ins itself, but I may have just mis-remembered.

Anyway, no idea.

@antirotor antirotor merged commit c751094 into develop May 3, 2024
@antirotor antirotor deleted the enhancement/add-3dequalizer-support branch May 3, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants