Resolve: version swap retain offset and IDT#43
Merged
jakubjezek001 merged 4 commits intodevelopfrom Mar 19, 2024
Merged
Conversation
This commit adds functionality to copy the ACES input transform from a timeline clip to a new media item. It retrieves the IDT (Input Device Transform) property from the timeline clip and sets it on the new media item. Also, it updates the ClipLoader class in plugin.py to read trimming information from the timeline item instead of using "Start" and "End" properties. The start time is calculated as the left offset of the timeline item, and the end time is calculated by adding the duration of the timeline item to its start time. These changes improve compatibility and ensure accurate copying of clips in Ayon Core Resolve API.
Member
Author
Minkiu
approved these changes
Feb 20, 2024
Contributor
Minkiu
left a comment
There was a problem hiding this comment.
Untested, but code looks good.
tokejepsen
suggested changes
Feb 26, 2024
Contributor
tokejepsen
left a comment
There was a problem hiding this comment.
Tested in Resolve 18.6. Failed when updating the clip, but I cant find any error messages anywhere. Where would the logs go?
Member
Author
|
Look into Resolve's console. |
Contributor
|
This will need resolving before we can test this; #160 |
Member
Author
this issue had been resolved from today, please try it again. |
tokejepsen
approved these changes
Mar 19, 2024
Contributor
tokejepsen
left a comment
There was a problem hiding this comment.
Tested successfully in Resolve 18.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Swapped version should retain the offset and IDT.
Additional info
Ayon-core port of ynput/OpenPype#6128 and
closes ynput/OpenPype#6125 issue
Testing notes:
Note that earlier version doesn't match the timeline trim of the latest version, and IDT of the version resets to default