Maya: abc options for Pointcache/Animation family - AY-970 by tokejepsen · Pull Request #336 · ynput/ayon-core

tokejepsen · 2024-04-01T11:22:51Z

Changelog Description

Validate alembic defaults settings

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…cache-Animation-family # Conflicts: # openpype/hosts/maya/api/plugin.py # openpype/hosts/maya/plugins/create/create_animation.py # openpype/hosts/maya/plugins/create/create_pointcache.py # openpype/hosts/maya/plugins/publish/extract_pointcache.py

…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py # openpype/settings/defaults/project_settings/maya.json

…cache-Animation-family

…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py

client/ayon_core/hosts/maya/plugins/publish/validate_alembic_options_defaults.py

client/ayon_core/hosts/maya/api/alembic.py

client/ayon_core/hosts/maya/plugins/create/create_animation_pointcache.py

client/ayon_core/hosts/maya/plugins/publish/collect_animation.py

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…intcache.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

…ptions_defaults.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

…ache-Animation-family # Conflicts: # server_addon/maya/server/version.py

…n-family' of github.com:ynput/ayon-core into enhancement/AY-970_abc-options-for-Pointcache-Animation-family

BigRoy · 2024-04-30T13:43:04Z

Massive work everyone! :)

BigRoy · 2024-05-01T13:54:08Z

Getting this error after this PR:

Traceback (most recent call last):
  File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\dependency_packages\ayon_2404022047_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.3\ayon_core\hosts\maya\plugins\publish\validate_alembic_options_defaults.py", line 46, in process
    attributes = self._get_publish_attributes(instance)
  File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.3\ayon_core\hosts\maya\plugins\publish\validate_alembic_options_defaults.py", line 33, in _get_publish_attributes
    cls.plugin_name(
TypeError: 'str' object is not callable

BigRoy · 2024-05-01T14:08:20Z

Next error after that is:

DEBUG: Extracting pointcache..
Traceback (most recent call last):
  File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\dependency_packages\ayon_2404022047_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\Maqina-02\AppData\Local\Ynput\AYON\addons\core_0.3.1-dev.3\ayon_core\hosts\maya\plugins\publish\extract_pointcache.py", line 165, in process
    "writeCreases", self.writeCreases
AttributeError: 'ExtractAnimation' object has no attribute 'writeCreases'

BigRoy · 2024-05-01T14:15:32Z

Next error is:

Traceback (most recent call last):
  File "C:\Users\User\AppData\Local\Ynput\AYON\dependency_packages\ayon_2403071252_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "E:\dev\ayon-core\client\ayon_core\hosts\maya\plugins\publish\extract_pointcache.py", line 218, in process
    extract_alembic(**kwargs)
TypeError: extract_alembic() got an unexpected keyword argument 'userAttr'

I get the feeling this PR was merged too quickly? :D

BigRoy · 2024-05-01T15:28:30Z

server_addon/maya/server/settings/publishers.py

+        "renderableOnly": False,
+        "stripNamespaces": True,
+        "uvsOnly": False,
+        "uvWrite": False,


Do we really feel this is a sensible studio default we should offer from AYON by default. With this False by default Alembics will be written without UVs - pretty sure we'll want to flip that. Right @tokejepsen @mkolar ?

BigRoy · 2024-05-01T15:29:10Z

server_addon/maya/server/settings/publishers.py

+        "bake_attributes": [],
+        "bake_attribute_prefixes": [],
+        "dataFormat": "ogawa",
+        "eulerFilter": False,


This defaulted to True before, by making this False with this PR this now means there is a difference in default behavior.

BigRoy · 2024-05-01T15:29:56Z

server_addon/maya/server/settings/publishers.py

+        "writeFaceSets": False,
+        "writeNormals": True,
+        "writeUVSets": False,
+        "writeVisibility": False


This defaulted to True before this PR - with this now False any animated visibilities (or even any visilities whatsoever) will not be published along. Do we feel that's a sensible default value for AYON?

BigRoy · 2024-05-01T15:33:14Z

client/ayon_core/hosts/maya/api/alembic.py

+    frameRange="",
+    noNormals=False,
+    preRoll=False,
+    preRollStartFrame=0,


Pretty sure this functionality does not work?

I'm seeing this in my extraction logs:

# Warning: Ignoring unsupported flag: -preRollStartFrame # Warning: Ignoring unsupported flag: 0

It seems preRollStartFrame is not a job argument but a direct argument to AbcExport. See logic here. So the current implementation here is broken. @tokejepsen that will have to be rewritten a different way then.

tokejepsen and others added 30 commits June 21, 2023 17:10

initial working version of abc options.

e19e7e1

Docs

d87e64e

Hound

c07729d

Backwards compatibility attributes.

e4a7641

Debug logging

cda9089

Remove redundant code.

1a5201a

Failsafe

0342870

Ensure includeUserDefinedAttributes gets correct value

fab76c6

Update openpype/hosts/maya/plugins/publish/collect_pointcache.py

9923328

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Hound

b601aa6

Ensure list arguments are valid

b63f5c5

BigRoy feedback

e722fbe

Fix list arguments.

38be2be

Working animation family

5aa5215

Hound

2f8dafd

Initial working animation family

e447e6a

Working pointcache

9ac4017

Revert post_imprint

c1e771b

Combine CreateAnimation and CreatePointCache

9887035

Merge branch 'develop' into enhancement/OP-5920_abc-options-for-Point…

711fe5d

…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py # openpype/settings/defaults/project_settings/maya.json

Working merge of develop

eafe2d0

Working hidden animation creator

7d1f009

Merge branch 'develop' into enhancement/OP-5920_abc-options-for-Point…

d8ee0a6

…cache-Animation-family

Merge branch 'develop' into enhancement/OP-5920_abc-options-for-Point…

178f184

…cache-Animation-family

Fix writeNormals

fcf1c1e

Remove redundant code.

ee8b230

Add tooltip to preRollStartFrame

de5c1ce

Merge branch 'develop' into enhancement/OP-5920_abc-options-for-Point…

af6f157

…cache-Animation-family # Conflicts: # openpype/hosts/maya/plugins/create/create_animation.py

Sync with develop plugin.py

7f152b9

iLLiCiTiT reviewed Apr 15, 2024

View reviewed changes

client/ayon_core/hosts/maya/plugins/publish/validate_alembic_options_defaults.py Outdated Show resolved Hide resolved

BigRoy reviewed Apr 15, 2024

View reviewed changes

tokejepsen and others added 12 commits April 15, 2024 14:58

Update client/ayon_core/hosts/maya/plugins/publish/extract_pointcache.py

affb42e

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Update client/ayon_core/hosts/maya/plugins/create/create_animation_po…

9aff312

…intcache.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Update client/ayon_core/hosts/maya/plugins/publish/validate_alembic_o…

40eea96

…ptions_defaults.py Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Split ValidateAlembicOptionsDefaults

f8a8fa4

Update client/ayon_core/hosts/maya/api/alembic.py

4cb9ee5

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Update client/ayon_core/hosts/maya/api/alembic.py

d730e81

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Remove writeNormals

838ae0c

Fix instance defs.

26791c9

Update client/ayon_core/hosts/maya/plugins/publish/collect_animation.py

ba5c62b

Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>

Merge branch 'develop' into enhancement/AY-970_abc-options-for-Pointc…

abd5733

…ache-Animation-family # Conflicts: # server_addon/maya/server/version.py

Increment maya version

636bebc

Merge branch 'enhancement/OP-5920_abc-options-for-Pointcache-Animatio…

e805338

…n-family' of github.com:ynput/ayon-core into enhancement/AY-970_abc-options-for-Pointcache-Animation-family

tokejepsen requested review from BigRoy and iLLiCiTiT April 27, 2024 10:30

mkolar merged commit c918bea into develop Apr 30, 2024

mkolar deleted the enhancement/OP-5920_abc-options-for-Pointcache-Animation-family branch April 30, 2024 13:40

BigRoy mentioned this pull request Apr 30, 2024

Maya: Fix extract_alembic imports #477

Merged

BigRoy mentioned this pull request May 1, 2024

Maya: Fix Maya Alembic Extractors #478

Merged

BigRoy reviewed May 1, 2024

View reviewed changes

BigRoy mentioned this pull request Jul 3, 2024

enhancement: Maya Pointcache export allow exporting -userAttr instead of -attr ynput/OpenPype#4812

Closed

2 tasks

BigRoy mentioned this pull request Oct 16, 2024

Alembic Exports: Do not force a preroll starting at frame 0 ynput/ayon-maya#151

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Maya: abc options for Pointcache/Animation family - AY-970#336

Maya: abc options for Pointcache/Animation family - AY-970#336
mkolar merged 236 commits intodevelopfrom
enhancement/OP-5920_abc-options-for-Pointcache-Animation-family

tokejepsen commented Apr 1, 2024 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy commented Apr 30, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy May 1, 2024

Uh oh!

BigRoy May 1, 2024

Uh oh!

BigRoy May 1, 2024

Uh oh!

BigRoy May 1, 2024

Uh oh!

BigRoy May 1, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Conversation

tokejepsen commented Apr 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BigRoy commented Apr 30, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy commented May 1, 2024

Uh oh!

BigRoy May 1, 2024

Choose a reason for hiding this comment

Uh oh!

BigRoy May 1, 2024

Choose a reason for hiding this comment

Uh oh!

BigRoy May 1, 2024

Choose a reason for hiding this comment

Uh oh!

BigRoy May 1, 2024

Choose a reason for hiding this comment

Uh oh!

BigRoy May 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

tokejepsen commented Apr 1, 2024 •

edited

Loading

BigRoy May 1, 2024 •

edited

Loading