Merged
Conversation
18 tasks
Minkiu
reviewed
Nov 7, 2023
|
|
||
| async for row in Postgres.iterate(query, transaction=transaction): | ||
| parent_path = "/".join(row["path"].split("/")[:-1]) | ||
| parent_path = "/".join(row["path"].strip("/").split("/")[:-1]) |
Contributor
There was a problem hiding this comment.
Maybe we could do the strip above and use the new var later on too:
row_path = row["path"].strip("/")
parent_path = "/".join(row_path.split("/")[:-1]
...
cache[row_path] = attr
Contributor
|
I know this is beyond the scope of this PR, but wondered if it might be worth using We could then do stuff like: from pathlib import Path
...
# row["path"] = "/assets/characters/xenomorph"
row_path = Path(row["path"])
row_path.parent # PosixPath('/assets/characters')
row_path.parent.relative_to("/") # PosixPath('assets/characters')
row_path.relative_to("/") # PosixPath('assets/characters/xenomorph')
row_path.as_posix() # '/assets/characters/xenomorph' |
Member
|
I believe this has now bee rigorously tested and can be merged now. |
mkolar
approved these changes
Nov 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API (both rest and graphql) now returns folder paths prefixed with a slash (as in unix absolute paths).
It is a backward compatible change as everywhere API ACCEPTS a folder path (graphql filters, access control), it allows using both prefixed and unprefixed versions.