Backend support for project bundles#521
Conversation
|
I can create dev project bundle, that probably should not be allowed. |
|
For some reason I cannot create project bundle now because it thinks I don't have core available. EDITED: |
The UI is really just a proof-of-work. @Innders will need to look at it and polish it :-I |
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces project bundle support to allow per‐project customization of addon versions and settings. Key changes include:
- Adding a new GraphQL type (ProjectBundleType) and updating resolvers and nodes to expose bundle data.
- Updating API endpoints and models (settings, projects, bundles, addons) to handle project bundle parameters and validations.
- Introducing stricter validations and error messages for project bundles in bundle creation and update flows.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ayon_server/graphql/resolvers/projects.py | Updated resolver to check for "projectBundle" presence. |
| ayon_server/graphql/nodes/project.py | Added ProjectBundleType and made several fields optional. |
| ayon_server/addons/definition.py | Introduced a property for project override capability. |
| ayon_server/addons/addon.py | Added a method to return project override configuration. |
| api/settings/settings.py | Extended query parameters and response model for bundles. |
| api/projects/bundle.py | Added endpoint for setting project bundles. |
| api/projects/init.py | Updated module exports with the new bundle endpoint. |
| api/bundles/models.py | Included a new field to mark bundles as project bundles. |
| api/bundles/bundles.py | Added validations and updated error messages for project bundles. |
| api/addons/list_addons.py | Updated addon list response to include project override info. |
Comments suppressed due to low confidence (1)
api/settings/settings.py:347
- [nitpick] The assert message 'Bundle name is None' includes informal language ('shut up pyright') which should be revised to a more professional error message.
bundle_name is not None
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…s://github.com/ynput/ayon-backend into 513-bundle-per-project-add-server-side-support
antirotor
left a comment
There was a problem hiding this comment.
I've tested bundles creation, deletion, usage of specific bundles, listing bundles - all works well.
kalisp
left a comment
There was a problem hiding this comment.
Looks good, played with bundles for a while, updated settings, used dev/prod/staging in my launcher, values were picked correctly from Settings.
There was a problem hiding this comment.
I was able to find the new changes in the api. (didn't test them, my main review about backward compitablity)
tested launcher in dev and production modes.
testing changing few settings in dev and prod bundles.
everything seems to work as usual.
also, I was able to create bundles and copy settings.
This pull request introduces several changes to the
apiandayon_servermodules to support project-specific addon versions and project bundles. The most important changes include adding new fields to models, updating bundle handling logic, and introducing new endpoints for project bundles.