This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Hiero: colorspace settings aligned with nuke - AY-978#6249
Merged
jakubjezek001 merged 9 commits intodevelopfrom Apr 9, 2024
Merged
Conversation
Member
|
@tokejepsen once this is finalized can we create the port into |
Co-authored-by: Jakub Ježek <jakubjezek001@gmail.com>
jakubjezek001
suggested changes
Apr 9, 2024
Member
jakubjezek001
left a comment
There was a problem hiding this comment.
lets apply suggestions so it is ready for merge
Member
|
This should also have |
jakubjezek001
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
In order to share the same colorspaces in the workfile in Hiero and Nuke, we need to bring back the workfile settings for colorspaces in Nuke.
In Hiero we also need code to edit the project settings in memory and apply the colorspaces when launching Hiero so any new project gets the correct colorspaces. Due to Foundry not providing Python API methods for setting the project colorspaces, we need to go through the UI widgets to set them, when dealing with in-memory projects.
Also small bugfix when saving the workfile without any sequences.
Testing notes:
project_settings/global/imageio/activate_global_color_management