Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Push to project - AY-742#6245

Merged
mkolar merged 7 commits intodevelopfrom
feature/AY-742_copy-to-breakdown-project
May 3, 2024
Merged

Nuke: Push to project - AY-742#6245
mkolar merged 7 commits intodevelopfrom
feature/AY-742_copy-to-breakdown-project

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Mar 18, 2024 •
edited
Loading

Changelog Description

This introduces the "Push to Project" menu item in Nuke.

This enables users to push the current workfile to a different project and copy all files from Read nodes to a resources folder next to the workfile. Containers will be baked to normal Read nodes.

Also gizmos will be baked to groups.

Testing notes:

  1. In Nuke have some Read nodes and containers.
  2. Go to OpenPype > Push to Project
  3. Choose a project, asset, task and variant. Variant is technically not needed for the workfile, but I didnt want to modify the Push to Library Project code too much.
  4. Hit Push.
  5. Launch the workfile in the chosen project. It wont open on launch, cause the workfile naming is wrong, but this is intentional so its works like a version 0.
  6. Validate all Read nodes works with paths from the resources folder.

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Mar 18, 2024
@ynbot ynbot added type: feature Larger, user affecting changes and completely new things size/S Denotes a PR changes 100-499 lines, ignoring general files host: Nuke labels Mar 18, 2024
jakubjezek001
jakubjezek001 suggested changes Apr 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is opening window under Nuke app and locking the Nuke for editing. It is not very clear on first glance what happened and it looks like something is broken. After while I had figured out that pop-up-ed window is opened under the nuke and that it is blocking the main thread. This will need to be fixed.

@jakubjezek001
Copy link
Copy Markdown
Member

jakubjezek001 commented Apr 3, 2024

Also, it raises the question of whether we should convert the OCIO config environment variable to a customOCIOconfig path as an absolute value. Alternatively, is it acceptable to keep the current expression and add it, as I have done in this example?
[regsub -all {\\} [getenv BUILTIN_OCIO_ROOT] "/"]/aces_1.2/config.ocio

@tokejepsen
Copy link
Copy Markdown
Contributor Author

tokejepsen commented Apr 8, 2024

Also, it raises the question of whether we should convert the OCIO config environment variable to a customOCIOconfig path as an absolute value. Alternatively, is it acceptable to keep the current expression and add it, as I have done in this example?
[regsub -all {\} [getenv BUILTIN_OCIO_ROOT] "/"]/aces_1.2/config.ocio

We could, but if the OCIO environment variable is set, then it'll override anyways, so not sure it'll be worth it atm?

@tokejepsen tokejepsen requested a review from jakubjezek001 April 8, 2024 13:20
jakubjezek001
jakubjezek001 approved these changes Apr 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakubjezek001
Copy link
Copy Markdown
Member

jakubjezek001 commented Apr 26, 2024

We could, but if the OCIO environment variable is set, then it'll override anyways, so not sure it'll be worth it atm?

Sure, it's fine for now. If we run into the problem later, we can handle it when it comes up.

@tokejepsen tokejepsen mentioned this pull request Apr 28, 2024
Merged
@mkolar mkolar merged commit da96c71 into develop May 3, 2024
@ynbot ynbot added this to the next-patch milestone May 3, 2024
@tokejepsen tokejepsen deleted the feature/AY-742_copy-to-breakdown-project branch May 3, 2024 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakubjezek001 jakubjezek001

Labels

host: Nuke port to AYON size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested type: feature Larger, user affecting changes and completely new things

Projects

PR reviewing
Archived in project

Milestone

3.18.10

Development

Successfully merging this pull request may close these issues.

4 participants

@tokejepsen @jakubjezek001 @mkolar @ynbot