Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Maya: Fix Redshift cryptomatte multipartEXR#6240

Merged
antirotor merged 8 commits intodevelopfrom
bugfix/AY-3649_Fix-Redshift-cryptomatte-multipartEXR
Apr 10, 2024
Merged

Maya: Fix Redshift cryptomatte multipartEXR#6240
antirotor merged 8 commits intodevelopfrom
bugfix/AY-3649_Fix-Redshift-cryptomatte-multipartEXR

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

Changelog Description

When using Redshift and rendering multipart EXRs, the instances for cryptomatte AOVs are getting falsely marked as multipart EXR even though they are being forced to be separate files by Redshift.

Since we cannot query the AOVs multipart individually, we'll need a hardcoded rule.

Ideally I guess AOVs should be separate instances in the publishing process but that is too big of a scope atm.

Testing notes:

  1. Configure Redshift render in Maya for multipart EXR and add Cryptomatte AOVs.
  2. Publish and validate that only the main render instance has "multipartExr": true in the metadata json.

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Mar 9, 2024
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Mar 9, 2024
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All working well with multipart EXR and Cryptomatte aov...

Here is a scrngrab of JSON with that attrib turned FALSE

Screenshot 2024-03-11 154915

The job were finnished successfully and also published fine.

Im also enclosing the JSON for clarification.
renderLookdevMain_metadata.json.txt

@tokejepsen tokejepsen marked this pull request as draft March 18, 2024 07:44
@LiborBatek LiborBatek self-requested a review March 19, 2024 15:40
@tokejepsen tokejepsen requested a review from BigRoy April 7, 2024 21:25
@tokejepsen tokejepsen marked this pull request as ready for review April 7, 2024 21:26
@tokejepsen tokejepsen requested a review from BigRoy April 9, 2024 11:42
@tokejepsen
Copy link
Copy Markdown
Contributor Author

@LiborBatek could I get another test of this?

tokejepsen and others added 2 commits April 9, 2024 15:11
Co-authored-by: Roy Nieterau <roy_nieterau@hotmail.com>
@tokejepsen tokejepsen requested a review from BigRoy April 9, 2024 14:15
Copy link
Copy Markdown
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wish this could've been 'simpler' and 'cleaner' - but the big comment does explain some of the reasoning behind it. I guess it does what it should.

Code changes make sense - didn't test it.

Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re did the testing and all working ok, DL job finnished without any errors, all renders been integrated as well and finally the JSON file contain the multipart: false flag too...

All goood. good to go IMHO!

@antirotor antirotor merged commit 2671534 into develop Apr 10, 2024
@ynbot ynbot added this to the next-patch milestone Apr 10, 2024
@tokejepsen tokejepsen deleted the bugfix/AY-3649_Fix-Redshift-cryptomatte-multipartEXR branch April 11, 2024 07:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

port to AYON size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants