Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Fusion: fix unwanted change to field name in Settings#6193

Merged
kalisp merged 1 commit intodevelopfrom
bugfix/OP-8104_Fusion-createImageSaver
Feb 5, 2024
Merged

Fusion: fix unwanted change to field name in Settings#6193
kalisp merged 1 commit intodevelopfrom
bugfix/OP-8104_Fusion-createImageSaver

Conversation

@kalisp
Copy link
Copy Markdown
Member

@kalisp kalisp commented Feb 2, 2024

Changelog Description

It should be image_format but in previous refactoring PR it fell back to original output_formats which caused enum not to show up and propagate into plugin.

Additional info

Previously:
uwqmpRpzVR
Now:
chrome_XJzvOBzdXV
In images:
fuscript_xehsgoTsDA

Testing notes:

  1. Update Settings - set output format
  2. create image and render instances in fusion, watch that change in Setting propagated into creators

It should be image_format but in previous refactoring PR it fell back to original output_formats
@ynbot ynbot added host: Fusion size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working labels Feb 2, 2024
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ayon Settings work fine

image

got correctly propagated and working when Publish

image

@kalisp kalisp merged commit d377b28 into develop Feb 5, 2024
@kalisp kalisp deleted the bugfix/OP-8104_Fusion-createImageSaver branch February 5, 2024 09:32
@ynbot ynbot added this to the next-patch milestone Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

host: Fusion size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants