This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Conversation
the djvview does not have model and is unused, probably forgotten
Member
|
@iLLiCiTiT could you pls elaborate more on what should the check look like pls? like for what should I check and where before/after. Im not really sure in this case... thx! |
Member
Author
|
This change did (should) not change anything. So testing is really that "nothing has changed". |
kalisp
approved these changes
Feb 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
The djv does not have group defined in models so the values are not used anywhere.
Additional info
Values were probably remainders after movement of the settings from OpenPype. DJV has own addon with own path settings. Version change is not necessary as this change does not affect anything in the addon.
Testing notes:
Validate that any applications addon before this PR did not have djv in UI.