Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

AYON settings: Use bundle name as variant in dev mode#6187

Merged
iLLiCiTiT merged 1 commit intodevelopfrom
bugfix/always-use-bundle-name-as-dev-variant
Feb 1, 2024
Merged

AYON settings: Use bundle name as variant in dev mode#6187
iLLiCiTiT merged 1 commit intodevelopfrom
bugfix/always-use-bundle-name-as-dev-variant

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

Changelog Description

Make sure the bundle name is used in dev mode for settings variant.

Additional info

Bundle name was used as variant only if was assigned to current user which broke most of automations where service users were used.

Testing notes:

  1. Use dev bundle name for automation where service API key is used (e.g. on farm).
  2. It should not crash on settings call where would be variant "dev".

@iLLiCiTiT iLLiCiTiT requested a review from kalisp February 1, 2024 14:46
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Feb 1, 2024
Copy link
Copy Markdown
Member

@kalisp kalisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue.

@kalisp kalisp assigned iLLiCiTiT and unassigned kalisp Feb 1, 2024
@iLLiCiTiT iLLiCiTiT merged commit 7b3d54a into develop Feb 1, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/always-use-bundle-name-as-dev-variant branch February 1, 2024 17:34
@ynbot ynbot added this to the next-patch milestone Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants