Max: updated implementation of save_scene + small QOL improvements to host#6186
Max: updated implementation of save_scene + small QOL improvements to host#6186moonyuet merged 8 commits intoynput:developfrom
Conversation
has_unsaved_changes seems to be legacy as indicated by the base class. It was already unused/implemented. Replaced with working version workfiles_has_unsaved_changes
…class mirrored Houdini implementation
|
Thank you! |
Co-authored-by: Kayla Man <64118225+moonyuet@users.noreply.github.com>
moonyuet
left a comment
There was a problem hiding this comment.
Looks good for me, Thank you!
LiborBatek
left a comment
There was a problem hiding this comment.
Seems working fine...
The UI switched correctly to the Create tab and publishing working fine too.
My only concern being, it always says "No unsaved changes, skipping file save..."
I simply couldnt force to perform Save action if any changes made to the active work file...
@moonyuet anything to add to it? maybe my expectations being wrong.
maybe we can error out the collector if there is unsaved change (similar to what we did in maya). Otherwise no debug message. |
It should be printing INFO already, just tested again to be sure it's working as intended and all good on my end? I mirrored the logic that Houdini implementation currently uses, so if we do decide to tweak probably good to also do that. |
Changelog Description
has_unsaved_changesfrom Max host as it looks to have been unused and unimplemented.workfile_has_unsaved_changesto Max host.save_scenepublish for Max.startup.mswhich opens the usual 'default' menu inside of Max (see screenshots).Current (Likely opens this menu due to one or more of the startup scripts used to insert OP menu):
New:
Additional info
It's my understanding that the
has_unsaved_changesis now legacy so I have replaced and implemented it usingworkfile_has_unsaved_changes.The change to the
startup.msis really just QOL for artists as the view it currently defaults to is not useful nor is it the usual default.Testing notes:
save_sceneis NOT saving if no changes to scene were made; or is saving when changes have been made (it should display INFO or DEBUG information in either case).