Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Nuke: Camera product type loaded is not updating - OP-7973#6184

Merged
jakubjezek001 merged 3 commits intodevelopfrom
bugfix/OP-7973_camera-product-type-loaded-is-not-updating
Feb 9, 2024
Merged

Nuke: Camera product type loaded is not updating - OP-7973#6184
jakubjezek001 merged 3 commits intodevelopfrom
bugfix/OP-7973_camera-product-type-loaded-is-not-updating

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Feb 1, 2024

Changelog Description

When updating the camera this error would appear:

(...)openpype/hosts/nuke/plugins/load/load_camera_abc.py", line 142, in update
    camera_node = nuke.toNode(object_name)
TypeError: toNode() argument 1 must be str, not Node

Testing notes:

  1. Load alembic camera in Nuke.
  2. Update alembic camera.

@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files host: Nuke type: bug Something isn't working labels Feb 1, 2024
moonyuet
moonyuet approved these changes Feb 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with the testing note, looks good for me in loading, switching version and updating the container
image

jakubjezek001
jakubjezek001 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkolar
Copy link
Copy Markdown
Member

mkolar commented Feb 8, 2024

Happy to merge when we see AYON port.

@tokejepsen tokejepsen mentioned this pull request Feb 9, 2024
Merged
@jakubjezek001 jakubjezek001 merged commit e2f447e into develop Feb 9, 2024
@ynbot ynbot added this to the next-patch milestone Feb 9, 2024
@jakubjezek001 jakubjezek001 deleted the bugfix/OP-7973_camera-product-type-loaded-is-not-updating branch February 9, 2024 15:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@moonyuet moonyuet moonyuet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakubjezek001 jakubjezek001

Labels

host: Nuke size/XS Denotes a PR changes 0-99 lines, ignoring general files target: AYON target: OpenPype type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.7

Development

Successfully merging this pull request may close these issues.

5 participants

@tokejepsen @mkolar @jakubjezek001 @moonyuet @ynbot