This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Publisher: Show message with error on action failure#6179
Merged
jakubjezek001 merged 5 commits intodevelopfrom Feb 7, 2024
Merged
Publisher: Show message with error on action failure#6179jakubjezek001 merged 5 commits intodevelopfrom
jakubjezek001 merged 5 commits intodevelopfrom
Conversation
Collaborator
|
Could you share a screen capture of what this looks like? Does the error show in the Report? I'm asking because it has also often come up that there's also NO response whatsoever from a succesful run of an action where the action does produce logs and preferably that output would be visualized. I wonder whether that case could also be solved with code similar to this. |
Contributor
Author
Its separate pop-up window, similar to when creation fails.
I've just snug in code for displaying "Action finished." similar to the "Refreshed" card. Shh.... |
iLLiCiTiT
reviewed
Jan 30, 2024
iLLiCiTiT
reviewed
Jan 31, 2024
iLLiCiTiT
reviewed
Jan 31, 2024
iLLiCiTiT
approved these changes
Jan 31, 2024
Member
iLLiCiTiT
left a comment
There was a problem hiding this comment.
Code changes make sense, but didn't test it.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
This PR adds support for the publisher to show error message from running actions.
Errors from actions will otherwise be hidden from user in various console outputs.
Also include card for when action is finished.
Testing notes:
Not sure about a simpler test case, so this where I caught it.
ayon+settings://nuke/create/CreateWriteRender/exposed_knobsenter an invalid knob name likecreate_directo.renderin Nuke. Error will appear about missing knob.create_directoon the created instance node.