Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

AYON: Use SettingsField from ayon server#6173

Merged
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/use-settings-field-in-ayon-settings
Jan 26, 2024
Merged

AYON: Use SettingsField from ayon server#6173
iLLiCiTiT merged 4 commits intodevelopfrom
enhancement/use-settings-field-in-ayon-settings

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT commented Jan 26, 2024 •
edited by LiborBatek
Loading

Changelog Description

This is preparation for new version of pydantic which will require to customize the field class for AYON purposes as raw pydantic Field could not be used.

Testing notes:

  1. Create server packages.
  2. Upload packages to AYON server.
  3. Restart server.
  4. Add the addon versions to a bundle.
  5. Try to open each addon settings (all of them should be visible and working).
  • aftereffects
  • applications
  • blender
  • celaction
  • clockify
  • core
  • deadline
  • fusion
  • hiero
  • houdini
  • max
  • maya
  • nuke
  • photoshop
  • resolve
  • royal render
  • substancepainter
  • timers manager
  • traypublisher
  • tvpaint
  • unreal

@iLLiCiTiT
use 'SettingsField' from ayon server instead of 'Field' from pydantic
3ea4c29 
This is preparation for new version of pydantic which will require to customize the field for AYON purposes and raw pydantic Field could not be used.
@BigRoy
Copy link
Copy Markdown
Collaborator

BigRoy commented Jan 26, 2024

Interesting - outside of this PR this could have quite an influence on anyone having customized settings on top of AYON. They would need to align.

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

@iLLiCiTiT
Copy link
Copy Markdown
Member Author

iLLiCiTiT commented Jan 26, 2024

Not sure when the pydantic update is 'scheduled' but it would be good to maybe make a clear announcement to devs to make sure to refactor along because say "in a month" or so pydantic will update and using Field will start to fail.

It is not scheduled at this moment. I think it will happen when all addons will be separated, pre-requirement for separation is to renamed openpype to ayon_core, so they'd have to do more changes than this anyway...

LiborBatek
LiborBatek approved these changes Jan 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through all Settings for Ayon Addons and all seems fine and present. With all options available.

I did also compare it side by side to a server before this PR. so should be 100% proven.

Note: I also did those missing in the list like SiteSync and Slack...were working and looking fine too!

@kalisp kalisp assigned iLLiCiTiT and unassigned LiborBatek Jan 26, 2024
@iLLiCiTiT iLLiCiTiT merged commit f3b1570 into develop Jan 26, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/use-settings-field-in-ayon-settings branch January 26, 2024 17:05
@ynbot ynbot added this to the next-patch milestone Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@kalisp kalisp Awaiting requested review from kalisp

@antirotor antirotor Awaiting requested review from antirotor

@jakubjezek001 jakubjezek001 Awaiting requested review from jakubjezek001

1 more reviewer

@LiborBatek LiborBatek LiborBatek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

host: After Effects host: Blender host: CelAction CelAction 2d animation package host: Flame Autodesk Flame integration host: Fusion host: Harmony host: Hiero host: Houdini host: Maya host: Nuke host: Photoshop host: Resolve host: Substance Painter host: TrayPublisher host: TV Paint host: UE host: 3dsmax Autodesk 3dsmax module: Deadline AWS Deadline related features size/XXL Denotes a PR changes 2500+ lines, ignoring general files target: AYON type: enhancement Enhancements to existing functionality

Projects

PR reviewing
Archived in project

Milestone

3.18.6

Development

Successfully merging this pull request may close these issues.

4 participants

@iLLiCiTiT @BigRoy @LiborBatek @ynbot