Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

ExtractOIIOTranscode: Missing product_names to subsets conversion#6159

Merged
iLLiCiTiT merged 2 commits intodevelopfrom
bugfix/extract_oiio_transcode
Jan 25, 2024
Merged

ExtractOIIOTranscode: Missing product_names to subsets conversion#6159
iLLiCiTiT merged 2 commits intodevelopfrom
bugfix/extract_oiio_transcode

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Jan 24, 2024 •
edited by jakubjezek001
Loading

Changelog Description

The Product Names filtering should be fixed with this.

Testing notes:

  1. Setup ayon+settings://core/publish/ExtractReview/profiles/0/outputs?project=demo_Commercial as below;
    Capture
  2. Submit render from Maya to Deadline.
  3. Inspect Deadline jobs logs that the ExtractOIIOTranscode is working on the render.

@tokejepsen tokejepsen requested a review from iLLiCiTiT January 24, 2024 12:22
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 24, 2024
jakubjezek001
jakubjezek001 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Jan 24, 2024

Task linked: OP-8005 Maya: transcoding issue with missing RGBA channels

@tokejepsen tokejepsen assigned LiborBatek and unassigned iLLiCiTiT Jan 25, 2024
@tokejepsen tokejepsen requested a review from LiborBatek January 25, 2024 09:05
@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Jan 25, 2024

Note: Im testing it right now (before get merged) will update here soon...

LiborBatek
LiborBatek approved these changes Jan 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works as expected! No errors given and job successfully finnished on DL and product integrated on Ayon server...

maya 2024 and arnold

image

@tokejepsen
Copy link
Copy Markdown
Contributor Author

tokejepsen commented Jan 25, 2024

All works as expected! No errors given and job successfully finnished on DL and product integrated on Ayon server...

Could you post the Deadline job report?

@LiborBatek
Copy link
Copy Markdown
Member

LiborBatek commented Jan 25, 2024

Yeah, here you have the Publish Job (DL) report:

Job_2024-01-25_16-55-31_65b284734e1c57cf378118c5.txt

@tokejepsen
Copy link
Copy Markdown
Contributor Author

tokejepsen commented Jan 25, 2024

Yeah, here you have the Publish Job (DL) report:

Cool, it actually ended up skipping the OIIO transcode due to the regex .*[mM]ain\b excludes renderLookdevMain_beauty, but it still proves the code is working.

We really need some documentation on the whole OIIO transcode for renders from Maya. Especially when dealing with render pases.

@tokejepsen tokejepsen assigned antirotor and unassigned LiborBatek Jan 25, 2024
@iLLiCiTiT iLLiCiTiT merged commit ec49203 into develop Jan 25, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/extract_oiio_transcode branch January 25, 2024 17:18
@ynbot ynbot added this to the next-patch milestone Jan 25, 2024
@jakubjezek001 jakubjezek001 changed the title ExtractOIIOTranscode: Missing product_names to subsets conversion. ExtractOIIOTranscode: Missing product_names to subsets conversion - OP-8005 Jan 25, 2024
@jakubjezek001 jakubjezek001 changed the title ExtractOIIOTranscode: Missing product_names to subsets conversion - OP-8005 ExtractOIIOTranscode: Missing product_names to subsets conversion Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

2 more reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@LiborBatek LiborBatek LiborBatek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@antirotor antirotor

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.6

Development

Successfully merging this pull request may close these issues.

7 participants

@tokejepsen @ynbot @LiborBatek @BigRoy @jakubjezek001 @antirotor @iLLiCiTiT