This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Chore: Collect template data with hierarchy context#6154
Merged
jakubjezek001 merged 3 commits intodevelopfrom Jan 23, 2024
Merged
Chore: Collect template data with hierarchy context#6154jakubjezek001 merged 3 commits intodevelopfrom
jakubjezek001 merged 3 commits intodevelopfrom
Conversation
jakubjezek001
approved these changes
Jan 23, 2024
64qam
approved these changes
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Fixed queue loop where is used wrong variable to pop items from queue.
Additional info
Also create copy of hierarchy context to be sure it is not modified during the loop in any way (just to be sure for possible future changes), and don't store 'hierarchyContext' to variable when checking if is set.
Testing notes: