Hiero: Effect Categories - OP-7397#6143
Conversation
|
Task linked: OP-7397 Hiero: separate effect to lut and repos |
jakubjezek001
left a comment
There was a problem hiding this comment.
awesome work! Can we also add default values as you were showing in documentation into the variable DEFAULT_PUBLISH_PLUGIN_SETTINGS?
jakubjezek001
left a comment
There was a problem hiding this comment.
Also it seems like the exported effects json is not correct. In my case it had published the contect like this a01vfxd_sh010_effectPlateP01Look_v001.json
{
"assignTo": "plateP01"
}
Timeline effects
Publisher instances are correct
Conclusion:
It is not collecting soft effect nodes and then those are not serialized into json files.
I would maybe argue that we should not have any defaults to maintain backwards compatibility? |
@jakubjezek001 I'm not entirely sure what you meant here, but I've fixed the case where effects are not categorized, in which case we just dump the effects into the "main" effects. |
jakubjezek001
left a comment
There was a problem hiding this comment.
Once the suggestion is implemented anyhow, then it is good for merge.
Co-authored-by: Jakub Ježek <jakub@ynput.io>
Changelog Description
This PR introduces
Effect Categoriesfor the Hiero settings. This allows studios to split effect stacks into meaningful subsets.Testing notes:
Effect Categoriesin Hiero addon settings (see documentation).