This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Chore: Transcoding extensions add missing '.tif' extension#6142
Merged
Chore: Transcoding extensions add missing '.tif' extension#6142
Conversation
BigRoy
reviewed
Jan 16, 2024
Collaborator
There was a problem hiding this comment.
I believe we had this fixed on our branch as well, and also added it here.
Note that for whatever reason it doesn't use the same list - and also note that .tiff shows twice like you fixed this IMAGE_EXTENSIONS set as well.
Also with the amount of lookups being done on that other one I suspec that should really be a set as well as opposed to list.
There are also some usages of standalone publisher plugins referring to tiff but no tif entry being present, in collect textures, validate frame range,
jakubjezek001
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Image extensions in transcoding helper was missing
.tifextension and had.tifftwice.Additional info
Reorganized extensions a little to be alphabetically sorted.