This repository was archived by the owner on Sep 20, 2024. It is now read-only.
Conversation
BigRoy
approved these changes
Jan 16, 2024
Collaborator
BigRoy
left a comment
There was a problem hiding this comment.
Yup, makes sense. Without this it would be:
Unresolved attribute reference '_failed_representations' for class 'CreatePlaceholderItem'
Didn't test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Description
Use correct variable where failed instances are stored for validation.
Additional info
Current implementation was using
_failed_representationswhich was copied from load, but should use_failed_created_publish_instances.Testing notes:
Not sure how to test. Probably cause an error of create placeholder during workfile template builder.