Max: Implementation of Validate Render Passes by moonyuet · Pull Request #6138 · ynput/OpenPype

moonyuet · 2024-01-16T10:10:29Z

Changelog Description

This PR is to enhance the current validator of checking the render output before deadline publish. It does the following:

The validator Render Output for Deadline would be renamed as Validate Render Passes
The validator would not only check on the invalid render output folder but the invalid filename of render passes.

Additional info

n/a

Testing notes:

Launch Max via Launcher
Open a Renderable Scene
Create Some AOVs in Render Setting
Create Render Instance with your preferred camera(s)
Publish
If the AOVs dont have invalid name or render output folder doesn't match the max scene name, it will error out.
You can perform repair action once you encounter 7.

…passes

ynbot · 2024-01-16T10:10:32Z

Task linked: OP-7074 Validate Render Passes

…n legacy OP

openpype/hosts/max/plugins/publish/validate_renderpasses.py

LiborBatek

I did test in max 2023 with arnold render and even tho the Validator works fine for output file path (Im not sure speaking of AOVs names because I kept those at defaults) it errrors out with following error:

DEBUG: Response <RestApiResponse [200]>
Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2401161802_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\plugins\publish\save_scenes_for_cameras.py", line 37, in process
    new_output = RenderSettings().get_batch_render_output(camera)       # noqa
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\api\lib_rendersettings.py", line 190, in get_batch_render_output
    target_layer = rt.batchRenderMgr.GetView(target_layer_no)
RuntimeError: Unknown MAXScript exception raised.

moonyuet · 2024-01-25T08:18:03Z

I did test in max 2023 with arnold render and even tho the Validator works fine for output file path (Im not sure speaking of AOVs names because I kept those at defaults) it errrors out with following error:
``` DEBUG: Response Traceback (most recent call last): File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2401161802_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process runner(*args) File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\plugins\publish\save_scenes_for_cameras.py", line 37, in process new_output = RenderSettings().get_batch_render_output(camera) # noqa File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\openpype_3.18.5-nightly.3\openpype\hosts\max\api\lib_rendersettings.py", line 190, in get_batch_render_output target_layer = rt.batchRenderMgr.GetView(target_layer_no) RuntimeError: Unknown MAXScript exception raised. ```

it is more likely unrelated issue to the implementation of validator, I already created a PR to fix this issue: #6163

…e sure renderpass validated right

LiborBatek · 2024-01-26T12:28:29Z

I have been testing arnold and redshift with on purpose wrong output file path and the Validator checks correctly and fails. Also Repair action does work and fix the wrong set output file path.

Whats still mystery to me being AOVs because neither in arnold nor redshift I was not able to produce any (as products) on DL. So only main_beauty being produced.

@moonyuet any insight how it should work or how to setup correctly?

moonyuet · 2024-01-29T07:32:30Z

I have been testing arnold and redshift with on purpose wrong output file path and the Validator checks correctly and fails. Also Repair action does work and fix the wrong set output file path.
Whats still mystery to me being `AOVs` because neither in `arnold` nor `redshift` I was not able to produce any (as products) on DL. So only `main_beauty` being produced.
@moonyuet any insight how it should work or how to setup correctly?

It's normal case for Arnold not producing beauty as its API limitation doesn't allow to support AOVs temprarily.
But I will check out the issue found from Redshift.

moonyuet · 2024-01-29T08:20:02Z

You need to make sure you turn on separate AOV Files for this case

Maybe we can somehow support for user to customize multilayering in different PRs.

moonyuet · 2024-02-02T08:46:37Z

@LiborBatek I have created an issue for multilayering support in the settings.
For the current stage, you need to dive into render settings and set separateAovFile to render AOVs in separate files.

LiborBatek

After checking that Separate files for AOVs which took me some time to find (thx @moonyuet ) it works as expected.

My publishing and render being correctly produced.

antirotor

I've just quickly went throught the code and it looks fine

openpype/hosts/max/plugins/publish/validate_renderpasses.py

refactor the validate deadline publish and rename to validate render …

efc1cc2

…passes

ynbot added type: enhancement Enhancements to existing functionality host: 3dsmax Autodesk 3dsmax module: Deadline AWS Deadline related features size/S Denotes a PR changes 100-499 lines, ignoring general files labels Jan 16, 2024

moonyuet requested review from LiborBatek and antirotor January 16, 2024 10:14

add docstrings & fix the bug on the setting of validate render pass i…

f0b8f25

…n legacy OP

moonyuet marked this pull request as ready for review January 16, 2024 10:33

Merge branch 'develop' into enhancement/OP-7074_Validate-Render-Passes

90b74db