Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Missing nuke family Windows arguments#6131

Merged
iLLiCiTiT merged 3 commits intoynput:developfrom
tokejepsen:bugfix/nuke_family_arguments
Jan 19, 2024
Merged

Missing nuke family Windows arguments#6131
iLLiCiTiT merged 3 commits intoynput:developfrom
tokejepsen:bugfix/nuke_family_arguments

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Jan 15, 2024

Changelog Description

Default Windows arguments for launching the Nuke family was missing.

Testing notes:

  1. Setup AYON with default settings for applications.
  2. Launch Hiero/NukeAssist/NukeStudio.

@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 15, 2024
@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Jan 15, 2024 •
edited
Loading

@m-u-r-p-h-y & @LiborBatek I think they should be added to other platforms too? Aren't they missing in AYON settings too?

@m-u-r-p-h-y
Copy link
Copy Markdown
Member

m-u-r-p-h-y commented Jan 15, 2024

@m-u-r-p-h-y & @LiborBatek I think they should be added to other platforms too? Aren't they missing in AYON settings too?

definitively!

@tokejepsen
Copy link
Copy Markdown
Contributor Author

tokejepsen commented Jan 15, 2024

@m-u-r-p-h-y not sure how it works on Mac and Linux. Should I just add the same arguments to all platforms?

@iLLiCiTiT
Copy link
Copy Markdown
Member

iLLiCiTiT commented Jan 15, 2024

Should I just add the same arguments to all platforms?

Probably skip darwin, it has NukeAssist.xxx.app executable.

@tokejepsen
Copy link
Copy Markdown
Contributor Author

tokejepsen commented Jan 15, 2024

I think they should be added to other platforms too? Aren't they missing in AYON settings too?

Done

@tokejepsen tokejepsen requested review from iLLiCiTiT and removed request for jakubjezek001 January 15, 2024 14:57
@iLLiCiTiT iLLiCiTiT assigned jakubjezek001 and unassigned iLLiCiTiT Jan 19, 2024
iLLiCiTiT
iLLiCiTiT approved these changes Jan 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iLLiCiTiT iLLiCiTiT merged commit b8d4214 into ynput:develop Jan 19, 2024
@ynbot ynbot added this to the next-patch milestone Jan 19, 2024
@tokejepsen tokejepsen deleted the bugfix/nuke_family_arguments branch January 19, 2024 10:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@m-u-r-p-h-y m-u-r-p-h-y Awaiting requested review from m-u-r-p-h-y

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

2 more reviewers

@jakubjezek001 jakubjezek001 jakubjezek001 approved these changes

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jakubjezek001 jakubjezek001

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.5

Development

Successfully merging this pull request may close these issues.

5 participants

@tokejepsen @iLLiCiTiT @m-u-r-p-h-y @jakubjezek001 @ynbot