Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Transcoding: Fix reading image sequences through oiiotool#6129

Merged
iLLiCiTiT merged 2 commits intoynput:developfrom
tokejepsen:bugfix/transcoding_xml_parsing
Jan 15, 2024
Merged

Transcoding: Fix reading image sequences through oiiotool#6129
iLLiCiTiT merged 2 commits intoynput:developfrom
tokejepsen:bugfix/transcoding_xml_parsing

Conversation

@tokejepsen
Copy link
Copy Markdown
Contributor

@tokejepsen tokejepsen commented Jan 12, 2024

Changelog Description

When transcoding image sequences, the second image onwards includes the invalid xml line of Reading path/to/file.exr of the oiiotool output.

This is most likely not the best solution, but it fixes the issue and illustrates the problem.

Error:

ERROR:pyblish.plugin:Traceback (most recent call last):
  File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2310271602_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\Users\tokejepsen\OpenPype\openpype\plugins\publish\extract_color_transcode.py", line 152, in process
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 1136, in convert_colorspace
    input_info = get_oiio_info_for_input(input_path, logger=logger)
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 124, in get_oiio_info_for_input
    output.append(parse_oiio_xml_output(xml_text, logger=logger))
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 276, in parse_oiio_xml_output
    tree = xml.etree.ElementTree.fromstring(xml_string)
  File "xml\etree\ElementTree.py", line 1347, in XML
xml.etree.ElementTree.ParseError: syntax error: line 1, column 0
Traceback (most recent call last):
  File "C:\Users\tokejepsen\AppData\Local\Ynput\AYON\dependency_packages\ayon_2310271602_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "<string>", line 152, in process
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 1136, in convert_colorspace
    input_info = get_oiio_info_for_input(input_path, logger=logger)
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 124, in get_oiio_info_for_input
    output.append(parse_oiio_xml_output(xml_text, logger=logger))
  File "C:\Users\tokejepsen\OpenPype\openpype\lib\transcoding.py", line 276, in parse_oiio_xml_output
    tree = xml.etree.ElementTree.fromstring(xml_string)
  File "xml\etree\ElementTree.py", line 1347, in XML
xml.etree.ElementTree.ParseError: syntax error: line 1, column 0

Testing notes:

  1. Ensure ayon+settings://core/publish/ExtractOIIOTranscode?project=demo_Commercial is setup to transcode.
  2. Publish an image sequence (render) from Maya.
  3. Should error in Deadline on the publish job.

@tokejepsen tokejepsen added the sponsored Client endorsed or requested label Jan 12, 2024
@tokejepsen tokejepsen requested a review from iLLiCiTiT January 12, 2024 17:31
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 12, 2024
iLLiCiTiT
iLLiCiTiT reviewed Jan 15, 2024
View reviewed changes
@iLLiCiTiT iLLiCiTiT merged commit e9387c1 into ynput:develop Jan 15, 2024
@ynbot ynbot added this to the next-patch milestone Jan 15, 2024
@tokejepsen tokejepsen deleted the bugfix/transcoding_xml_parsing branch January 15, 2024 18:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BigRoy BigRoy Awaiting requested review from BigRoy

1 more reviewer

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files sponsored Client endorsed or requested type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.4

Development

Successfully merging this pull request may close these issues.

4 participants

@tokejepsen @BigRoy @iLLiCiTiT @ynbot