Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Chore: Template data for editorial publishing#6120

Merged
iLLiCiTiT merged 5 commits intodevelopfrom
bugfix/OP-7711_Hiero-editorial-product-publishing-under-wrong-context-3182
Jan 12, 2024
Merged

Chore: Template data for editorial publishing#6120
iLLiCiTiT merged 5 commits intodevelopfrom
bugfix/OP-7711_Hiero-editorial-product-publishing-under-wrong-context-3182

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

Changelog Description

Template data for editorial publishing are filled during CollectInstanceAnatomyData. The structure for editorial is determined, as it's required for ExtractHierarchy AYON/OpenPype plugins.

Additional info

Right now the template data work only in TrayPublisher where context "anatomyData" do not contain current context, whereas in e.g. Hiero there is already filled asset so all instances will actually get filled wrong data, and files are integrated under editorial task.

This issue raised question: Should we allow to pass folder and task data from context to instances?

Testing notes:

Do these steps in AYON/OpenPype and Hiero/TrayPublisher

  1. Create new project (to have clean hierarchy in project management and files on disk).
  2. Run hierarchy publishing on the project.
  3. Validate that new hierarchy is created in project management and integrated files of each instances are at correct place.

@ynbot
Copy link
Copy Markdown
Contributor

ynbot commented Jan 11, 2024

@ynbot ynbot added type: bug Something isn't working size/S Denotes a PR changes 100-499 lines, ignoring general files labels Jan 11, 2024
Copy link
Copy Markdown
Member

@jakubjezek001 jakubjezek001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in OP and AY in Hiero and Traypublisher. Also tested effect product form Hiero with use of LUT file for resources path. All was working well as expected. Thanks @iLLiCiTiT

@iLLiCiTiT iLLiCiTiT merged commit 47cf95e into develop Jan 12, 2024
@iLLiCiTiT iLLiCiTiT deleted the bugfix/OP-7711_Hiero-editorial-product-publishing-under-wrong-context-3182 branch January 12, 2024 09:13
@ynbot ynbot added this to the next-patch milestone Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size/S Denotes a PR changes 100-499 lines, ignoring general files sponsored Client endorsed or requested target: AYON target: OpenPype type: bug Something isn't working

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants