Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Site Sync: small fixes in Loader#6119

Merged
kalisp merged 6 commits intodevelopfrom
bugfix/site_sync_issues_in_loader
Jan 12, 2024
Merged

Site Sync: small fixes in Loader#6119
kalisp merged 6 commits intodevelopfrom
bugfix/site_sync_issues_in_loader

Conversation

@kalisp
Copy link
Copy Markdown
Member

@kalisp kalisp commented Jan 11, 2024

Changelog Description

Resolves issue:

  • local and studio icons were same, they should be different
  • TypeError: string indices must be integers error when downloading/uploading workfiles

Testing notes:

  1. enable Site Sync for your project (must be enabled in Studio settings and Project Settings too!)
  2. set in Local settings active_site to 'local' and remote_site to 'studio`
  3. check Availability icons in Ayon Loader
  4. try do download workfile

kalisp added 2 commits January 11, 2024 13:51
@kalisp
Fix usage of correct values
622668e 
Returned item is dictionary of version_id: links, previous loop was looping through [[]].
@kalisp
Fix usage of studio icon
3e0fb62 
local and studio have both same provider, local_drive. Both of them should be differentiate by icon though.
@kalisp kalisp requested a review from LiborBatek January 11, 2024 15:01
@ynbot ynbot added type: bug Something isn't working size/XS Denotes a PR changes 0-99 lines, ignoring general files labels Jan 11, 2024
iLLiCiTiT
iLLiCiTiT reviewed Jan 11, 2024
View reviewed changes
iLLiCiTiT
iLLiCiTiT reviewed Jan 11, 2024
View reviewed changes
kalisp added 2 commits January 11, 2024 17:56
@kalisp
Fix - pull only paths from icon_def
d51b7f3 
Icon_def is dictionary with `type` and `path` keys, not directly 'path'.
It must be massaged first.
@kalisp
Merge branch 'develop' of https://github.com/ynput/OpenPype into bugf…
0804aa2 
…ix/site_sync_issues_in_loader
iLLiCiTiT
iLLiCiTiT reviewed Jan 12, 2024
View reviewed changes
kalisp and others added 2 commits January 12, 2024 10:39
@kalisp @iLLiCiTiT
Revert back, fixed in different PR
f1f5cce 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp @iLLiCiTiT
Fix looping
1887ffa 
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp kalisp merged commit 0461540 into develop Jan 12, 2024
@kalisp kalisp deleted the bugfix/site_sync_issues_in_loader branch January 12, 2024 09:44
@ynbot ynbot added this to the next-patch milestone Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@LiborBatek LiborBatek Awaiting requested review from LiborBatek

1 more reviewer

@iLLiCiTiT iLLiCiTiT iLLiCiTiT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@iLLiCiTiT iLLiCiTiT

Labels

size/XS Denotes a PR changes 0-99 lines, ignoring general files type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

3.18.3

Development

Successfully merging this pull request may close these issues.

3 participants

@kalisp @iLLiCiTiT @ynbot