Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

Kitsu: Clear credentials is safe#6116

Merged
iLLiCiTiT merged 1 commit intodevelopfrom
enhancement/safe-kitsu-credentials-cleanup
Jan 12, 2024
Merged

Kitsu: Clear credentials is safe#6116
iLLiCiTiT merged 1 commit intodevelopfrom
enhancement/safe-kitsu-credentials-cleanup

Conversation

@iLLiCiTiT
Copy link
Copy Markdown
Member

Changelog Description

Do not remove not existing keyring items.

Testing notes:

  1. Enable kitsu and setup url
  2. Make sure you don't have existing kitsu login in keyring (credentials manager on windows)
  3. Start tray and open kitsu login dialog
  4. Uncheck Remember checkbox
  5. Login
  6. It should not crash

Resolves #6115

@iLLiCiTiT iLLiCiTiT requested a review from Tilix4 January 10, 2024 09:32
@ynbot ynbot added size/XS Denotes a PR changes 0-99 lines, ignoring general files type: enhancement Enhancements to existing functionality module: Kitsu Kitsu integration labels Jan 10, 2024
@mkolar
Copy link
Copy Markdown
Member

mkolar commented Jan 11, 2024

@iLLiCiTiT is this OP only?

@iLLiCiTiT
Copy link
Copy Markdown
Member Author

@iLLiCiTiT is this OP only?

Yes, ayon addon already have the fix implemented.

@iLLiCiTiT iLLiCiTiT merged commit 1eb7e59 into develop Jan 12, 2024
@iLLiCiTiT iLLiCiTiT deleted the enhancement/safe-kitsu-credentials-cleanup branch January 12, 2024 11:25
@ynbot ynbot added this to the next-patch milestone Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community contribution module: Kitsu Kitsu integration size/XS Denotes a PR changes 0-99 lines, ignoring general files target: OpenPype type: enhancement Enhancements to existing functionality

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Bug: Kitsu login ui spawns No such password! error

5 participants